feat: support private master images in helm (#1008)

determined-ai · Aug 4, 2020 · 01ccd12 · 01ccd12
1 parent f781320
commit 01ccd12
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 0 deletions.
diff --git a/helm/charts/determined/templates/master-deployment.yaml b/helm/charts/determined/templates/master-deployment.yaml
@@ -23,12 +23,21 @@ spec:
       serviceAccount: determined-master-{{ .Release.Name }}
       containers:
       - name: determined-master-{{ .Release.Name }}
+        {{- if .Values.enterpriseEdition }}
+        {{- if .Values.detVersion }}
+        # detVersion is used for CI to override the appVersion.
+        image: determinedai/determined-ee-master:{{ .Values.detVersion }}
+        {{- else }}
+        image: determinedai/determined-ee-master:{{ required "A valid Chart.AppVersion entry required!" .Chart.AppVersion }}
+        {{- end }}
+        {{ else }}
         {{- if .Values.detVersion }}
         # detVersion is used for CI to override the appVersion.
         image: determinedai/determined-master:{{ .Values.detVersion }}
         {{- else }}
         image: determinedai/determined-master:{{ required "A valid Chart.AppVersion entry required!" .Chart.AppVersion }}
         {{- end }}
+        {{- end }}
         imagePullPolicy: "Always"
         volumeMounts:
           - name: master-config
@@ -42,6 +51,10 @@ spec:
             {{- if .Values.masterMemRequest }}
             memory: {{ .Values.masterMemRequest  | quote }}
             {{- end}}
+      {{- if .Values.enterpriseEdition }}
+      imagePullSecrets:
+      - name: {{ required "A valid Values.imagePullSecretName entry is required!" .Values.imagePullSecretName | quote}}
+      {{- end }}
       volumes:
         - name: master-config
           configMap:

diff --git a/helm/charts/determined/values.yaml b/helm/charts/determined/values.yaml
@@ -66,6 +66,12 @@ taskContainerDefaults:
   # ncclPortRange: <MIN:MAX>
   # glooPortRange: <MIN:MAX>
 
+# Configure Determined enterprise edition.
+enterpriseEdition: false
+
+# Should be configured if using the Determined enterprise edition master.
+# imagePullSecretName: regcred
+
 ## Configure whether we collect anonymous information about the usage of Determined.
 telemetry:
   enabled: true