use a redirectOnDelete flag for lighter footprint

determined-ai · Dec 1, 2023 · 11dbf93 · 11dbf93
1 parent 5e7c978
commit 11dbf93
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 11 deletions.
diff --git a/webui/react/src/components/DeleteModelModal.tsx b/webui/react/src/components/DeleteModelModal.tsx
@@ -1,20 +1,21 @@
 import { Modal } from 'hew/Modal';
 
+import { paths } from 'routes/utils';
 import { deleteModel } from 'services/api';
 import { ModelItem } from 'types';
 import handleError, { ErrorLevel, ErrorType } from 'utils/error';
 import { routeToReactUrl } from 'utils/routes';
 
 interface Props {
-  listPath?: string;
   model: ModelItem;
+  redirectOnDelete?: boolean;
 }
 
-const DeleteModelModal = ({ listPath, model }: Props): JSX.Element => {
+const DeleteModelModal = ({ model, redirectOnDelete = false }: Props): JSX.Element => {
   const handleOk = async () => {
     try {
       await deleteModel({ modelName: model.name });
-      if (listPath) routeToReactUrl(listPath);
+      if (redirectOnDelete) routeToReactUrl(paths.workspaceDetails(model.workspaceId, 'models'));
     } catch (e) {
       handleError(e, {
         level: ErrorLevel.Error,

diff --git a/webui/react/src/pages/ModelDetails/ModelHeader.tsx b/webui/react/src/pages/ModelDetails/ModelHeader.tsx
@@ -16,7 +16,6 @@ import ModelMoveModal from 'components/ModelMoveModal';
 import TimeAgo from 'components/TimeAgo';
 import Avatar from 'components/UserAvatar';
 import usePermissions from 'hooks/usePermissions';
-import { paths } from 'routes/utils';
 import userStore from 'stores/users';
 import { ModelItem, Workspace } from 'types';
 import { formatDatetime } from 'utils/datetime';
@@ -149,12 +148,6 @@ const ModelHeader: React.FC<Props> = ({
     [deleteModelModal, modelEditModal, modelMoveModal, onSwitchArchive],
   );
 
-  const listPath = useMemo(
-    () =>
-      model.workspaceId ? paths.workspaceDetails(model.workspaceId, 'models') : paths.modelList(),
-    [model.workspaceId],
-  );
-
   return (
     <header className={css.base}>
       {model.archived && (
@@ -180,7 +173,7 @@ const ModelHeader: React.FC<Props> = ({
         </div>
         <Glossary content={infoRows} />
       </div>
-      <deleteModelModal.Component listPath={listPath} model={model} />
+      <deleteModelModal.Component model={model} redirectOnDelete />
       <modelMoveModal.Component model={model} />
       <modelEditModal.Component fetchModel={fetchModel} model={model} />
     </header>