Skip to content

Commit

Permalink
ci: delete broken fixture (#8428)
Browse files Browse the repository at this point in the history
There is a fixture which runs the following command:

    det cmd --config resources.slots=1 "'sleep 30'"

It has never worked because it is missing the `run` subcommand.

Why fix a broken fixture when tests are fine without it?
  • Loading branch information
rb-determined-ai authored Nov 16, 2023
1 parent bf07e61 commit 1b47bf0
Showing 1 changed file with 0 additions and 7 deletions.
7 changes: 0 additions & 7 deletions e2e_tests/tests/conftest.py
Original file line number Diff line number Diff line change
Expand Up @@ -102,13 +102,6 @@ def pytest_addoption(parser: Parser) -> None:
parser.addoption("--no-compare-stats", action="store_true", help="Disable usage stats check")


@pytest.fixture(scope="session", autouse=True)
def instantiate_gpu() -> None:
command = ["det", "cmd", "--config", "resources.slots=1", "'sleep 30'"]

subprocess.run(command, universal_newlines=True, stdout=subprocess.PIPE, stderr=subprocess.PIPE)


@pytest.fixture(scope="session", autouse=True)
def cluster_log_manager(request: SubRequest) -> Iterator[Optional[ClusterLogManager]]:
master_scheme = request.config.getoption("--master-scheme")
Expand Down

0 comments on commit 1b47bf0

Please sign in to comment.