Skip to content

Commit

Permalink
fix: websocket upgrade failed in tensorboard [DET-8903] (#672)
Browse files Browse the repository at this point in the history
[e2e_tests changes only]
  • Loading branch information
eecsliu authored and rb-determined-ai committed Nov 2, 2023
1 parent 9cd91e4 commit db593a3
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions e2e_tests/tests/cluster/test_rbac_ntsc.py
Original file line number Diff line number Diff line change
Expand Up @@ -389,8 +389,10 @@ def can_access_logs(creds: authentication.Credentials, ntsc_id: str) -> bool:
# none of the users should be able to get details
for cred in [creds[1], creds[2]]:
session = determined_test_session(cred)
with pytest.raises(errors.APIException) as e:
get_ntsc_details(session, typ, created_id2)
# exception for creds[1], who can access the experiment and tensorboard
if typ != "tensorboard" and cred == creds[2]:
with pytest.raises(errors.APIException) as e:
get_ntsc_details(session, typ, created_id2)
assert e.value.status_code == 404
results = list_ntsc(session, typ)
for r in results:
Expand Down

0 comments on commit db593a3

Please sign in to comment.