Skip to content

Commit

Permalink
fix: reorder react routes to match more specific routes first (#943)
Browse files Browse the repository at this point in the history
  • Loading branch information
hamidzr authored Jul 23, 2020
1 parent 1f82faf commit df3c1e7
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion webui/react/src/pages/TrialLogs.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ const TrialLogs: React.FC = () => {
const { trialId } = useParams<Params>();
const id = parseInt(trialId);
const title = `Trial ${id} Logs`;
const downloadUrl = `${serverAddress()}/trials/${id}/logs?format=raw`;
const downloadUrl = `${serverAddress(true)}/trials/${id}/logs?format=raw`;
const setUI = UI.useActionContext();
const logsRef = useRef<LogViewerHandles>(null);
const [ oldestFetchedId, setOldestFetchedId ] = useState(Number.MAX_SAFE_INTEGER);
Expand Down
8 changes: 4 additions & 4 deletions webui/react/src/routes/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -111,14 +111,14 @@ const trialLogsRoute = {
export const defaultAppRoute = dashboardRoute;

export const appRoutes: RouteConfig[] = [
dashboardRoute,
experimentDetailsRoute,
trialLogsRoute,
trialDetailsRoute,
experimentListRoute,
experimentDetailsRoute,
taskListRoute,
experimentListRoute,
clusterRoute,
masterLogsRoute,
trialLogsRoute,
dashboardRoute,
{
component: SignIn,
id: 'login',
Expand Down

0 comments on commit df3c1e7

Please sign in to comment.