-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: correct expToWebhookConfig cache locking #10014
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10014 +/- ##
==========================================
- Coverage 54.59% 54.58% -0.02%
==========================================
Files 1258 1258
Lines 157136 157136
Branches 3617 3616 -1
==========================================
- Hits 85795 85771 -24
- Misses 71208 71232 +24
Partials 133 133
Flags with carried forward coverage won't be shown. Click here to find out more.
|
✅ Deploy Preview for determined-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, good catch!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix
Ticket
CM-527
Description
There is a write under a read lock, causing the master to crash in integration tests with
fatal error: concurrent map writes
.Test Plan
Change is a test fix.