test: add e2e tests to the "move project" functionality on the "List View" #10037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for determined-ui canceled.
|
thiagodallacqua-hpe
requested review from
JComins000,
EmilyBonar and
johnkim-det
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10037 +/- ##
==========================================
- Coverage 54.62% 50.59% -4.03%
==========================================
Files 1260 950 -310
Lines 157558 128921 -28637
Branches 3631 3632 +1
==========================================
- Hits 86066 65230 -20836
+ Misses 71358 63557 -7801
Partials 134 134
Flags with carried forward coverage won't be shown. Click here to find out more.
|
johnkim-det
reviewed
Oct 10, 2024
johnkim-det
reviewed
Oct 10, 2024
JComins000
reviewed
Oct 10, 2024
| @@ -42,4 +42,6 @@ export class InteractiveTable< | |||
|
|
|||
| readonly table: Table<RowType, HeadRowType>; | |||
| readonly skeleton = new SkeletonTable({ parent: this }); | |||
|
|
|||
| // TODO: add getRowByColumnValue (maybe base on the DataGrid model) | |||
There was a problem hiding this comment.
you can file this on me in the TESTENG project for basetable
thiagodallacqua-hpe
force-pushed
the
thiago/ET-757-1
branch
from
470de87
to
2ede599
Compare
JComins000
requested changes
Oct 10, 2024
JComins000
approved these changes
Oct 10, 2024
johnkim-det
reviewed
Oct 10, 2024
thiagodallacqua-hpe
force-pushed
the
thiago/ET-757-1
branch
from
5e5fc54
to
12e77b0
Compare
johnkim-det
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
ET-757
Description
Adds e2e tests for the "move project" functionality on the "List View" for the WorkspaceProjects.
Test Plan
projects.specfileChecklist
docs/release-notes/See Release Note for details.