refactor: remove annotations requiring search ids in bulk action js (ET-241) #10062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for determined-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10062 +/- ##
==========================================
- Coverage 54.42% 54.41% -0.01%
==========================================
Files 1262 1262
Lines 158886 158886
Branches 3630 3631 +1
==========================================
- Hits 86472 86465 -7
- Misses 72280 72287 +7
Partials 134 134
Flags with carried forward coverage won't be shown. Click here to find out more. |
AmanuelAaron
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
ET-241
Description
Removes annotations requiring fields that aren't actually logically required. Helps make the "select all" bulk action logic cleaner. There are some similar patterns on other bulk action APIs (like for experiments) but I'm less sure of the impact it'll have to change those so I think those should be handled separately if at all.
Test Plan
N/A
Checklist
docs/release-notes/See Release Note for details.