feat: add master logs [DET-3680] #1007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamidzr
commented
Aug 4, 2020
hamidzr
commented
Aug 4, 2020
hamidzr
commented
Aug 4, 2020
hamidzr
force-pushed
the
3680-master-logs
branch
from
4c00290
to
21a1882
Compare
hamidzr
commented
Aug 4, 2020
hamidzr
commented
Aug 4, 2020
master/internal/api_master.go
Outdated
| offset, limit := effectiveOffsetNLimit(int(req.Offset), int(req.Limit), total) | ||
|
|
||
| for { | ||
| for _, log := range a.m.logs.Entries(offset, -1, limit) { |
There was a problem hiding this comment.
@stoksc wouldn't this pin the CPU if there are no logs to send and the user has req.Follow set?
There was a problem hiding this comment.
Yep, looks like it would to me, nice catch. We could add a tiny timeout if it grabs a slice of entries without any logs (there are other things I can think of doing, but they're an order of magnitude more work)?
There was a problem hiding this comment.
alright that sounds good for now. I rather reserve more work for another PR so we can wrap this up without much change to the original work
stoksc
reviewed
Aug 4, 2020
master/internal/api_master.go
Outdated
| offset, limit := effectiveOffsetNLimit(int(req.Offset), int(req.Limit), total) | ||
|
|
||
| for { | ||
| for _, log := range a.m.logs.Entries(offset, -1, limit) { |
There was a problem hiding this comment.
Yep, looks like it would to me, nice catch. We could add a tiny timeout if it grabs a slice of entries without any logs (there are other things I can think of doing, but they're an order of magnitude more work)?
Co-authored-by: Bradley Laney <[email protected]>
rb-determined-ai
pushed a commit
that referenced
this pull request
Oct 5, 2023
New test of HuggingFace examples/hf_trainer_api/hf_language_modeling on pytorch2. Enabled for slurm_gpu + distributed marks.
rb-determined-ai
pushed a commit
that referenced
this pull request
Oct 10, 2023
New test of HuggingFace examples/hf_trainer_api/hf_language_modeling on pytorch2. Enabled for slurm_gpu + distributed marks.
stoksc
pushed a commit
that referenced
this pull request
Oct 17, 2023
New test of HuggingFace examples/hf_trainer_api/hf_language_modeling on pytorch2. Enabled for slurm_gpu + distributed marks.
rb-determined-ai
pushed a commit
that referenced
this pull request
Oct 27, 2023
New test of HuggingFace examples/hf_trainer_api/hf_language_modeling on pytorch2. Enabled for slurm_gpu + distributed marks.
rb-determined-ai
pushed a commit
that referenced
this pull request
Oct 31, 2023
New test of HuggingFace examples/hf_trainer_api/hf_language_modeling on pytorch2. Enabled for slurm_gpu + distributed marks.
rb-determined-ai
pushed a commit
that referenced
this pull request
Nov 2, 2023
New test of HuggingFace examples/hf_trainer_api/hf_language_modeling on pytorch2. Enabled for slurm_gpu + distributed marks.
rb-determined-ai
pushed a commit
that referenced
this pull request
Nov 2, 2023
New test of HuggingFace examples/hf_trainer_api/hf_language_modeling on pytorch2. Enabled for slurm_gpu + distributed marks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
a port of #988
Test Plan
Commentary (optional)