Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: clarify version overrides during helm installs #10094

Merged
merged 3 commits into from
Oct 24, 2024
Merged

chore: clarify version overrides during helm installs #10094

merged 3 commits into from
Oct 24, 2024

Conversation

amandavialva01
Copy link
Contributor

@amandavialva01 amandavialva01 commented Oct 22, 2024 •
edited by jira bot
Loading

Ticket

CM-582

Description

Clarify version overrides (detVersion in values.yaml overrides appVersion in Chart.yaml and --version in helm install and helm upgrade commands) during helm installs in our helm configuration reference docs

Test Plan

Checklist

  • Changes have been manually QA'd
  • New features have been approved by the corresponding PM
  • User-facing API changes have the "User-facing API Change" label
  • Release notes have been added as a separate file under docs/release-notes/
    See Release Note for details.
  • Licenses have been included for new code which was copied and/or modified from any external code

@cla-bot cla-bot bot added the cla-signed label Oct 22, 2024
@determined-ci determined-ci requested a review from a team October 22, 2024 14:32
@determined-ci determined-ci added the documentation Improvements or additions to documentation label Oct 22, 2024
@netlify Netlify
Copy link

netlify bot commented Oct 22, 2024 •
edited
Loading

✅ Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit bd7aec9
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/67194c3b88617d000830ed88

@amandavialva01 amandavialva01 requested review from tara-det-ai, a team and corban-beaird and removed request for a team October 22, 2024 14:36
tara-det-ai
tara-det-ai approved these changes Oct 23, 2024
View reviewed changes
Copy link
Member

@tara-det-ai tara-det-ai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@determined-ci determined-ci requested a review from a team October 23, 2024 19:12
@amandavialva01 amandavialva01 merged commit 11ea6f4 into main Oct 24, 2024
79 of 91 checks passed
@amandavialva01 amandavialva01 deleted the amanda/CM582 branch October 24, 2024 16:31
thiagodallacqua-hpe pushed a commit that referenced this pull request Oct 24, 2024
@amandavialva01 @thiagodallacqua-hpe
chore: clarify version overrides during helm installs (#10094)
212b090
thiagodallacqua-hpe pushed a commit that referenced this pull request Oct 28, 2024
@amandavialva01 @thiagodallacqua-hpe
chore: clarify version overrides during helm installs (#10094)
0e5b45d
thiagodallacqua-hpe pushed a commit that referenced this pull request Oct 28, 2024
@amandavialva01 @thiagodallacqua-hpe
chore: clarify version overrides during helm installs (#10094)
9ba90ad
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tara-det-ai tara-det-ai tara-det-ai approved these changes

@stoksc stoksc stoksc approved these changes

@corban-beaird corban-beaird Awaiting requested review from corban-beaird corban-beaird was automatically assigned from determined-ai/cluster-mgmt

Assignees
No one assigned
Labels
cla-signed documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@amandavialva01 @stoksc @tara-det-ai @determined-ci