test: Add test for filtering user by Role Id #10095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for determined-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10095 +/- ##
==========================================
- Coverage 54.43% 54.43% -0.01%
==========================================
Files 1267 1267
Lines 159371 159371
Branches 3631 3631
==========================================
- Hits 86749 86748 -1
- Misses 72488 72489 +1
Partials 134 134
Flags with carried forward coverage won't be shown. Click here to find out more. |
| }) | ||
| require.NoError(t, err) | ||
| require.Len(t, resp.Users, 1) | ||
| require.Equal(t, int32(user0.ID), resp.Users[0].Id) |
There was a problem hiding this comment.
we only want user0 and not user1 because the query filters to global assignments (ref here) right?
thiagodallacqua-hpe
pushed a commit
that referenced
this pull request
Oct 28, 2024
thiagodallacqua-hpe
pushed a commit
that referenced
this pull request
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Description
Add test for filtering user by Role id.
Migration of this PR
Test Plan
CI pass.
Checklist
docs/release-notes/See Release Note for details.