Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update copy in experiment and trial headers #10111

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

ashtonG
Copy link
Contributor

@ashtonG ashtonG commented Oct 23, 2024

Ticket

ET-837

Description

This updates the experiment header and the trial header to have correct copy when f_flat_runs is on.

Test Plan

with f_flat_runs on, visit a trial page

  • the experiment header should have the experiment id as search id_number
  • the trial header should have the trial id as run id_number

Checklist

  • Changes have been manually QA'd
  • New features have been approved by the corresponding PM
  • User-facing API changes have the "User-facing API Change" label
  • Release notes have been added as a separate file under docs/release-notes/
    See Release Note for details.
  • Licenses have been included for new code which was copied and/or modified from any external code

@ashtonG ashtonG requested a review from a team as a code owner October 23, 2024 19:56
@ashtonG ashtonG requested a review from gt2345 October 23, 2024 19:56
@cla-bot cla-bot bot added the cla-signed label Oct 23, 2024
Copy link

codecov bot commented Oct 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.50%. Comparing base (f45ebb9) to head (4235c9c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10111      +/-   ##
==========================================
- Coverage   54.48%   50.50%   -3.99%     
==========================================
  Files        1267      957     -310     
  Lines      159437   130657   -28780     
  Branches     3636     3638       +2     
==========================================
- Hits        86863    65982   -20881     
+ Misses      72441    64542    -7899     
  Partials      133      133              
Flag Coverage Δ
harness ?
web 54.02% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ages/ExperimentDetails/ExperimentDetailsHeader.tsx 74.32% <100.00%> (ø)
.../src/pages/TrialDetails/Header/TrialHeaderLeft.tsx 81.13% <100.00%> (+0.73%) ⬆️

... and 310 files with indirect coverage changes

@ashtonG ashtonG requested review from keita-determined and removed request for gt2345 October 23, 2024 19:56
Copy link

netlify bot commented Oct 23, 2024

Deploy Preview for determined-ui ready!

Name Link
🔨 Latest commit 4235c9c
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/671954f73bce8800084c403f
😎 Deploy Preview https://deploy-preview-10111--determined-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ashtonG ashtonG merged commit 993296b into main Oct 23, 2024
88 of 100 checks passed
@ashtonG ashtonG deleted the bug/ET-837/header-copy-change branch October 23, 2024 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants