Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improve messaging when workspace configs conflict with global … #10121

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

kkunapuli
Copy link
Contributor

@kkunapuli kkunapuli commented Oct 24, 2024

…constraints

Ticket

CM-588

Description

When the config/constraint conflict happens because of global constraints, the error message is a bit confusing. For this case, add a note about global constraints.

Test Plan

None needed.

Checklist

  • Changes have been manually QA'd
  • New features have been approved by the corresponding PM
  • User-facing API changes have the "User-facing API Change" label
  • Release notes have been added as a separate file under docs/release-notes/
    See Release Note for details.
  • Licenses have been included for new code which was copied and/or modified from any external code

@cla-bot cla-bot bot added the cla-signed label Oct 24, 2024
Copy link

netlify bot commented Oct 24, 2024

Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit 80fb2eb
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/671a82c6683fbd0008854aad

Copy link

codecov bot commented Oct 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.55%. Comparing base (3c59233) to head (80fb2eb).
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10121      +/-   ##
==========================================
- Coverage   54.57%   54.55%   -0.02%     
==========================================
  Files        1267     1267              
  Lines      159526   159527       +1     
  Branches     3637     3637              
==========================================
- Hits        87058    87034      -24     
- Misses      72335    72360      +25     
  Partials      133      133              
Flag Coverage Δ
backend 45.92% <100.00%> (-0.05%) ⬇️
harness 72.56% <ø> (ø)
web 54.02% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
master/internal/configpolicy/utils.go 71.73% <100.00%> (+0.20%) ⬆️

... and 1 file with indirect coverage changes

@kkunapuli kkunapuli marked this pull request as ready for review October 24, 2024 17:43
@kkunapuli kkunapuli requested a review from a team as a code owner October 24, 2024 17:43
@kkunapuli kkunapuli merged commit 962810a into main Oct 24, 2024
89 of 101 checks passed
@kkunapuli kkunapuli deleted the kunapuli/enhance-error-msg-global-conflict branch October 24, 2024 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants