Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Deepspeed trainer release note #10135

Closed
wants to merge 2 commits into from

Conversation

MikhailKardash
Copy link
Contributor

@MikhailKardash MikhailKardash commented Oct 25, 2024

Description

Add release note for DeepSpeed Trainer

Test Plan

No testing required

Checklist

  • Changes have been manually QA'd
  • New features have been approved by the corresponding PM
  • User-facing API changes have the "User-facing API Change" label
  • Release notes have been added as a separate file under docs/release-notes/
    See Release Note for details.
  • Licenses have been included for new code which was copied and/or modified from any external code

@cla-bot cla-bot bot added the cla-signed label Oct 25, 2024
@determined-ci determined-ci requested a review from a team October 25, 2024 21:49
@determined-ci determined-ci added the documentation Improvements or additions to documentation label Oct 25, 2024
Copy link

codecov bot commented Oct 25, 2024

Codecov Report

Attention: Patch coverage is 73.19719% with 420 lines in your changes missing coverage. Please review.

Project coverage is 54.11%. Comparing base (e3c31f0) to head (0e9d157).
Report is 22 commits behind head on main.

Current head 0e9d157 differs from pull request most recent head c18d098

Please upload reports for the commit c18d098 to get more accurate results.

Files with missing lines Patch % Lines
...s/determined/pytorch/deepspeed/_deepspeed_trial.py 71.12% 108 Missing ⚠️
harness/determined/pytorch/deepspeed/_trainer.py 49.54% 56 Missing ⚠️
harness/determined/pytorch/_trainer_utils.py 57.50% 34 Missing ⚠️
...ts/experiment/integrations/test_deepspeed_trial.py 77.44% 30 Missing ⚠️
...determined/pytorch/deepspeed/_deepspeed_context.py 53.22% 29 Missing ⚠️
harness/determined/keras/_callback.py 85.92% 28 Missing ⚠️
harness/determined/transformers/_hf_callback.py 78.57% 24 Missing ⚠️
harness/determined/pytorch/_trainer.py 11.53% 23 Missing ⚠️
harness/tests/experiment/keras/test_callback.py 87.01% 20 Missing ⚠️
harness/determined/core/_distributed.py 21.73% 18 Missing ⚠️
... and 11 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10135      +/-   ##
==========================================
- Coverage   58.46%   54.11%   -4.36%     
==========================================
  Files         754     1258     +504     
  Lines      104292   156847   +52555     
  Branches     3642     3616      -26     
==========================================
+ Hits        60978    84876   +23898     
- Misses      43181    71838   +28657     
  Partials      133      133              
Flag Coverage Δ
backend 45.84% <ø> (+2.04%) ⬆️
harness 71.15% <73.19%> (ø)
web 54.01% <ø> (-0.29%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
harness/determined/_execution.py 74.44% <100.00%> (ø)
harness/determined/common/api/errors.py 76.36% <100.00%> (ø)
harness/determined/constants.py 100.00% <ø> (ø)
harness/determined/core/__init__.py 100.00% <ø> (ø)
harness/determined/core/_train.py 40.00% <ø> (ø)
harness/determined/keras/__init__.py 100.00% <100.00%> (ø)
harness/determined/keras/_load.py 90.00% <100.00%> (ø)
harness/determined/keras/_tf_keras_trial.py 81.53% <100.00%> (ø)
harness/determined/keras/callbacks.py 91.61% <100.00%> (ø)
harness/determined/launch/deepspeed.py 91.51% <100.00%> (ø)
... and 71 more

... and 489 files with indirect coverage changes

@azhou-determined azhou-determined requested review from a team as code owners October 25, 2024 23:46
@azhou-determined azhou-determined requested review from EmilyBonar, maxrussell and dannysauer and removed request for a team October 25, 2024 23:46
Base automatically changed from searcher-context-removal to main October 26, 2024 01:22
@determined-ci
Copy link
Collaborator

Docsite preview being generated for this PR.
You can (eventually) find the generated docsite here.

Copy link

netlify bot commented Oct 28, 2024

Deploy Preview for determined-ui ready!

Name Link
🔨 Latest commit c18d098
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/6723a636e9fc740008e2c252
😎 Deploy Preview https://deploy-preview-10135--determined-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@EmilyBonar EmilyBonar removed request for a team and EmilyBonar October 28, 2024 17:04
Copy link
Contributor

@maxrussell maxrussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why I'm helpful here, but LGTM.

@MikhailKardash
Copy link
Contributor Author

This release note is now included in #10182

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants