build: INFENG-937: Publish Helm chart release candidates #10141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add Helm makefile and CircleCI job to publish Helm chart release candidates. This is necessary to properly deploy release candidates onto the new release party cluster. Previously, bumpversion adjusted the chart version in Chart.yaml and committed that to the release branch, then rph used this in-tree version as a chart repository to do GKE cluster upgrades during testing. This is no longer possible, though, so we need to publish these release candidate versions. (We should probably be doing this anyway, in the interest of transparency.) This will create an additional GitHub release every time we cut a release candidate.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10141 +/- ##
==========================================
- Coverage 54.71% 54.71% -0.01%
==========================================
Files 1266 1266
Lines 159970 159970
Branches 3662 3662
==========================================
- Hits 87525 87524 -1
- Misses 72312 72313 +1
Partials 133 133
Flags with carried forward coverage won't be shown. Click here to find out more. |
✅ Deploy Preview for determined-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
thiagodallacqua-hpe
pushed a commit
that referenced
this pull request
Oct 28, 2024
INFENG-937: Publish Helm RCs Add Helm makefile and CircleCI job to publish Helm chart release candidates. This is necessary to properly deploy release candidates onto the new release party cluster. Previously, bumpversion adjusted the chart version in Chart.yaml and committed that to the release branch, then rph used this in-tree version as a chart repository to do GKE cluster upgrades during testing. This is no longer possible, though, so we need to publish these release candidate versions. (We should probably be doing this anyway, in the interest of transparency.) This will create an additional GitHub release every time we cut a release candidate.
thiagodallacqua-hpe
pushed a commit
that referenced
this pull request
Oct 28, 2024
INFENG-937: Publish Helm RCs Add Helm makefile and CircleCI job to publish Helm chart release candidates. This is necessary to properly deploy release candidates onto the new release party cluster. Previously, bumpversion adjusted the chart version in Chart.yaml and committed that to the release branch, then rph used this in-tree version as a chart repository to do GKE cluster upgrades during testing. This is no longer possible, though, so we need to publish these release candidate versions. (We should probably be doing this anyway, in the interest of transparency.) This will create an additional GitHub release every time we cut a release candidate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
INFENG-937
Description
This changeset adds a Helm makefile target and CircleCI job to publish release candidate Determined Helm charts. This is necessary to deploy release candidates onto the new GKE cluster.
Previously, bumpversion would increment the rc version of the Helm chart, then commit this to the release branch (along with other similar version bumps).
rphwould then use this in-tree version of the Helm chart to upgrade the Helm release on the (old/existing) release party GKE cluster. Because we aren't managing versions on disk anymore, though, we need to install the Helm chart from somewhere else, which means we have to publish it somewhere in the first place for ArgoCD to find. This is more consistent anyway; we already publish Python package release candidates, for example.We already publish production releases to helm.determined.ai, so this attempts to use that existing automation to publish release candidates.
Test Plan
We'll have to do this one live, unfortunately. I don't quite have the time to figure out how to modify the dryrun job to produce the results we want, especially given the additional automation that publishing Helm charts uses (GitHub Actions, specifically).
Checklist
docs/release-notes/See Release Note for details.