build: INFENG-940: Fix logic error in CircleCI config make-component job #10143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it to run dryrun and production jobs as the inverse of the dryrun boolean variable. I.e. the opposite behavior.
✅ Deploy Preview for determined-ui canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10143 +/- ##
==========================================
+ Coverage 54.25% 58.46% +4.21%
==========================================
Files 1259 754 -505
Lines 157257 104292 -52965
Branches 3642 3641 -1
==========================================
- Hits 85323 60978 -24345
+ Misses 71801 43181 -28620
Partials 133 133
Flags with carried forward coverage won't be shown. Click here to find out more. |
thiagodallacqua-hpe
pushed a commit
that referenced
this pull request
Oct 28, 2024
…job (#10143) Fix logic error in CircleCI config make-component job that would cause it to run dryrun and production jobs as the inverse of the dryrun boolean variable. I.e. the opposite behavior.
thiagodallacqua-hpe
pushed a commit
that referenced
this pull request
Oct 28, 2024
…job (#10143) Fix logic error in CircleCI config make-component job that would cause it to run dryrun and production jobs as the inverse of the dryrun boolean variable. I.e. the opposite behavior.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
INFENG-940
Description
Reverse the polarity of the CircleCI
make-componentjob so it obeys thedryrunboolean variable properly, otherwise it will work the opposite way.Test Plan
Obverse the if statement and make sure it's correct.
Checklist
docs/release-notes/See Release Note for details.