feat: e2e add experiment row "kill" action tests #10148
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10148 +/- ##
==========================================
- Coverage 54.35% 51.22% -3.13%
==========================================
Files 1259 1098 -161
Lines 157337 144890 -12447
Branches 3644 3643 -1
==========================================
- Hits 85517 74220 -11297
+ Misses 71687 70537 -1150
Partials 133 133
Flags with carried forward coverage won't be shown. Click here to find out more.
|
✅ Deploy Preview for determined-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
…opdown with move modal integration.
…d ExperimentStopModal component
thiagodallacqua-hpe
force-pushed
the
thiago/ET-662
branch
from
5b016db
to
fd15cac
Compare
- Introduce a time metric for search with a max time of 937 batches - Simplify experiment creation validation logic - Modify kill experiment functionality to check for cancellation status after kill
thiagodallacqua-hpe
force-pushed
the
thiago/ET-662
branch
from
cb2dc7f
to
c33c77e
Compare
thiagodallacqua-hpe
force-pushed
the
thiago/ET-662
branch
2 times, most recently
from
f3e7d95
to
9fa73d0
Compare
thiagodallacqua-hpe
force-pushed
the
thiago/ET-662
branch
from
9fa73d0
to
7fe0f4f
Compare
JComins000
reviewed
Oct 31, 2024
JComins000
reviewed
Oct 31, 2024
JComins000
approved these changes
Oct 31, 2024
|
just a few small comments. merge when you're ready |
thiagodallacqua-hpe
force-pushed
the
thiago/ET-662
branch
from
7fe0f4f
to
34e28eb
Compare
ashtonG
reviewed
Nov 4, 2024
thiagodallacqua-hpe
force-pushed
the
thiago/ET-662
branch
from
34e28eb
to
3bde7fc
Compare
|
Closing PR due to company restructuring. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
ET-662
Description
This Pr intends to add tests for the "kill" experiment row action for the DataGrid.
Test Plan
'Row Actions'test from thesrc/e2e/tests/experimentList.spec.tstest file.Checklist
docs/release-notes/See Release Note for details.