ci: no det version parameter via continued config #10151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for determined-ui canceled.
|
JComins000
force-pushed
the
jcom/INFENG-944/det-version-mismatch-from-pipeline
branch
from
9e93049
to
a94ed82
Compare
JComins000
force-pushed
the
jcom/INFENG-944/det-version-mismatch-from-pipeline
branch
from
c54a022
to
d2851e2
Compare
JComins000
force-pushed
the
jcom/INFENG-944/det-version-mismatch-from-pipeline
branch
from
9890b21
to
1c291e6
Compare
JComins000
force-pushed
the
jcom/INFENG-944/det-version-mismatch-from-pipeline
branch
from
e342bb3
to
65d14ab
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10151 +/- ##
=======================================
Coverage 54.26% 54.26%
=======================================
Files 1259 1259
Lines 157276 157276
Branches 3642 3641 -1
=======================================
+ Hits 85344 85345 +1
+ Misses 71799 71798 -1
Partials 133 133
Flags with carried forward coverage won't be shown. Click here to find out more. |
JComins000
force-pushed
the
jcom/INFENG-944/det-version-mismatch-from-pipeline
branch
from
dd80918
to
ac82fc2
Compare
JComins000
force-pushed
the
jcom/INFENG-944/det-version-mismatch-from-pipeline
branch
from
ac82fc2
to
70a34cd
Compare
JComins000
force-pushed
the
jcom/INFENG-944/det-version-mismatch-from-pipeline
branch
from
b0b3776
to
333ff1e
Compare
JComins000
force-pushed
the
jcom/INFENG-944/det-version-mismatch-from-pipeline
branch
from
2c9d075
to
8a7c7d8
Compare
JComins000
force-pushed
the
jcom/INFENG-944/det-version-mismatch-from-pipeline
branch
2 times, most recently
from
0ad48ea
to
49f01f4
Compare
JComins000
force-pushed
the
jcom/INFENG-944/det-version-mismatch-from-pipeline
branch
5 times, most recently
from
09485c9
to
e45d631
Compare
JComins000
force-pushed
the
jcom/INFENG-944/det-version-mismatch-from-pipeline
branch
3 times, most recently
from
86b758a
to
5f66e3a
Compare
JComins000
force-pushed
the
jcom/INFENG-944/det-version-mismatch-from-pipeline
branch
from
5f66e3a
to
63ffe35
Compare
davidfluck-hpe
requested changes
Oct 29, 2024
JComins000
commented
Oct 30, 2024
| @@ -13,15 +13,12 @@ orbs: | |||
| executors: | |||
| python-38: | |||
| docker: | |||
| - image: python:3.8-slim-bookworm | |||
There was a problem hiding this comment.
these didnt have git installed, so they couldn't run the script
JComins000
commented
Oct 30, 2024
| package-location: | ||
| type: string | ||
| steps: | ||
| - run: | ||
| name: Install <<parameters.package-name>> |
There was a problem hiding this comment.
this previously required pipeline.parameters.det-version, so idk why were were parameterizing on package name
There was a problem hiding this comment.
It looks like this could install any package the same way instead of only installing Determined. 🤷♂️ If it's only used for one package, then I agree that the parameter is unecessary.
(FWIW, the blame probably shows that I wrote all this stuff because I renamed the config file when switching to dynamic config. :))
There was a problem hiding this comment.
ohh okay! thanks for looking
davidfluck-hpe
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
https://hpe-aiatscale.atlassian.net/browse/INFENG-944
Description
The det-version parameter wasn't updating on rerun. Since we use a script, let's just use the script at runtime instead of config-time.
Test Plan
Checklist
docs/release-notes/See Release Note for details.