Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AUTO-BACKPORT 10138] feat: determined_master_host and friends helm support, better defaults #10159

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

github-actions[bot]
Copy link

Backport 4e374c3 from #10138.

#10138)

When `determined_master_ip` is unsettable via Helm and defaults to the service IP, life with proxies is hard. This change renames `determined_master_ip` to `determined_master_host` everywhere with some backwards compatibility, defaults `determined_master_host` to `<det_namespace>.<det_service_name>.svc.cluster.local`, and makes all of this overridable in Helm.

(cherry picked from commit 4e374c3)
@github-actions github-actions bot requested review from a team as code owners October 30, 2024 21:16
@github-actions github-actions bot requested review from jesse-amano-hpe and removed request for a team October 30, 2024 21:16
@cla-bot cla-bot bot added the cla-signed label Oct 30, 2024
Copy link

codecov bot commented Oct 30, 2024

Codecov Report

Attention: Patch coverage is 72.72727% with 18 lines in your changes missing coverage. Please review.

Project coverage is 54.26%. Comparing base (38ae54b) to head (0f827f7).
Report is 1 commits behind head on release-0.38.0.

Files with missing lines Patch % Lines
master/cmd/determined-master/root.go 75.55% 11 Missing ⚠️
master/internal/config/resource_manager_config.go 55.55% 4 Missing ⚠️
master/internal/rm/kubernetesrm/jobs.go 71.42% 2 Missing ⚠️
...nal/rm/kubernetesrm/kubernetes_resource_manager.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                 @@
##           release-0.38.0   #10159      +/-   ##
==================================================
+ Coverage           54.25%   54.26%   +0.01%     
==================================================
  Files                1259     1259              
  Lines              157257   157276      +19     
  Branches             3641     3641              
==================================================
+ Hits                85313    85347      +34     
+ Misses              71811    71796      -15     
  Partials              133      133              
Flag Coverage Δ
backend 45.91% <72.72%> (+0.04%) ⬆️
harness 71.15% <ø> (ø)
web 54.29% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
master/internal/rm/kubernetesrm/job.go 77.31% <100.00%> (+0.97%) ⬆️
master/internal/rm/kubernetesrm/spec.go 84.64% <100.00%> (ø)
...nal/rm/kubernetesrm/kubernetes_resource_manager.go 27.67% <0.00%> (ø)
master/internal/rm/kubernetesrm/jobs.go 70.62% <71.42%> (+0.48%) ⬆️
master/internal/config/resource_manager_config.go 64.46% <55.55%> (-1.42%) ⬇️
master/cmd/determined-master/root.go 57.50% <75.55%> (+5.22%) ⬆️

... and 4 files with indirect coverage changes

@stoksc
Copy link
Contributor

stoksc commented Oct 31, 2024

going to merge this over the know znode failures

@stoksc stoksc merged commit b366f80 into release-0.38.0 Oct 31, 2024
106 of 109 checks passed
@stoksc stoksc deleted the backport-10138-to-release-0.38.0 branch October 31, 2024 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant