feat: add experiment cancel and kill endpoints [DET-3581] #1026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamidzr
changed the title
hamidzr
changed the title
stoksc
approved these changes
Aug 6, 2020
| addr := actor.Addr("experiments", req.Id).String() | ||
| err = a.actorRequest(addr, req, &resp) | ||
| if status.Code(err) == codes.NotFound { | ||
| return &apiv1.CancelExperimentResponse{}, nil |
There was a problem hiding this comment.
question: this is ignored to be in line wanting most endpoints to be Idempotent?
There was a problem hiding this comment.
correct because at this point if actor doesn't find it it means that this experiment exists (in DB) but is in a terminal state. how does that sound to you
There was a problem hiding this comment.
yeah that sounds perfect to me, easiest behavior for a user to design stuff with imo.
Co-authored-by: Bradley Laney <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Test Plan
Commentary (optional)