docs: apply our own best practices in tutorials [DET-3800] #1054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rb-determined-ai
added
the
documentation
aaron276h
reviewed
Aug 11, 2020
There was a problem hiding this comment.
We need to update: https://docs.determined.ai/latest/tutorials/native-tf-keras/tf_keras_native_dtrain.html#sphx-glr-tutorials-native-tf-keras-tf-keras-native-dtrain-py to match this also. May want to add text about tempfile there also.
|
The document you linked to is a generated file via the sphinx gallery plugin (see docs/conf.py). |
aaron276h
approved these changes
Aug 11, 2020
azhou-determined
pushed a commit
that referenced
this pull request
Dec 7, 2023
* fix: formatting and removed echo * updated docs and fixed slurmcluster issue * chore: refactored to use case * fix: added error checking to generatetfvars.sh and updated documentation * fix: added time type to error output
wes-turner
pushed a commit
that referenced
this pull request
Feb 2, 2024
* fix: formatting and removed echo * updated docs and fixed slurmcluster issue * chore: refactored to use case * fix: added error checking to generatetfvars.sh and updated documentation * fix: added time type to error output
rb-determined-ai
pushed a commit
that referenced
this pull request
Feb 29, 2024
* fix: formatting and removed echo * updated docs and fixed slurmcluster issue * chore: refactored to use case * fix: added error checking to generatetfvars.sh and updated documentation * fix: added time type to error output
amandavialva01
pushed a commit
that referenced
this pull request
Mar 18, 2024
* fix: formatting and removed echo * updated docs and fixed slurmcluster issue * chore: refactored to use case * fix: added error checking to generatetfvars.sh and updated documentation * fix: added time type to error output
eecsliu
pushed a commit
that referenced
this pull request
Apr 18, 2024
* fix: formatting and removed echo * updated docs and fixed slurmcluster issue * chore: refactored to use case * fix: added error checking to generatetfvars.sh and updated documentation * fix: added time type to error output
eecsliu
pushed a commit
to determined-ai/determined-release-testing
that referenced
this pull request
Apr 22, 2024
…mined-ai#1054) * fix: formatting and removed echo * updated docs and fixed slurmcluster issue * chore: refactored to use case * fix: added error checking to generatetfvars.sh and updated documentation * fix: added time type to error output
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In addition to downloading to non-unique places, we were downloading before submitting the experiment, which is wrong by itself.
This fixes an broken test.
Test Plan
Still passes tests.