fix: remove cookie check during logout because of flake [DET-3823]

[hkang1]

Description

It seems like with cypress's whitelisting of the auth cookie, there is no guarantee that the cookie will be properly cleared under the testing environment. We currently have a url path check to confirm that the logout takes you to the sign in page, which should suffice. Simply removed the cookie check due to its flakiness.

Reference:
cypress-io/cypress#5723
cypress-io/cypress#5453

Test Plan

Commentary (optional)

[hkang1]

@hamidzr I've reran the e2e-tests multiple times and I think it's stable now. About 6~10 recent reruns in a row have passed. 🤞

[hkang1]

The most recent push change is around dropping unused comment lines.

[hamidzr]

Description

It seems like with cypress's whitelisting of the auth cookie, there is no guarantee that the cookie will be properly cleared under the testing environment. We currently have a url path check to confirm that the logout takes you to the sign in page, which should suffice. Simply removed the cookie check due to its flakiness.

Reference:
cypress-io/cypress#5723
cypress-io/cypress#5453

Test Plan

Commentary (optional)

I looked to see if we can test our test helpers but I don't know how to set it up to expect some tests or a specific cypress command to fail. there are assertions but I didn't see a clean way of using it.
jestjs/jest#10030

describe('Sign in/out test tests', () => {
  it('should login and checkLoggedIn', () => {
    cy.login();
    cy.checkLoggedIn();
  });

  it('should logout and checkLoggedOUt', () => {
    cy.logout();
    cy.checkLoggedOut();
  });

  it('should logout and fail checkLoggedIn', () => {
    cy.logout();
    cy.checkLoggedIn()
    // expect(cy.checkLoggedIn).to.throw();
  });

  it('should login and fail checkLoggedOut', () => {
    cy.login();
    cy.checkLoggedOut()
    expect(cy.checkLoggedOut).to.throw();
  });
});

[hamidzr]

LGTM, thanks for fixing this