Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: trigger the correct click handler [DET-3817] #1064

Merged
merged 1 commit into from
Aug 12, 2020
Merged

fix: trigger the correct click handler [DET-3817] #1064

merged 1 commit into from
Aug 12, 2020

Conversation

hkang1
Copy link
Contributor

@hkang1 hkang1 commented Aug 12, 2020 •
edited by jira bot
Loading

Description

Fix the Link component to reroute using the internal router instead of triggering the loading of a new page.

Test Plan

Commentary (optional)

@cla-bot cla-bot bot added the cla-signed label Aug 12, 2020
@hkang1 hkang1 requested a review from hamidzr August 12, 2020 07:31
@justin-determined-ai
Copy link
Contributor

Did you test this out?

hamidzr
hamidzr approved these changes Aug 12, 2020
View reviewed changes
Copy link
Member

@hamidzr hamidzr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this does the trick! thanks, @hkang1

@hamidzr
Copy link
Member

hamidzr commented Aug 12, 2020

Did you test this out?

yep the page navigation is definitely improved

event.preventDefault();
we weren't actually calling the click handler so it was working through normal hyperlink behavior.

@hamidzr hamidzr assigned hkang1 and unassigned hamidzr Aug 12, 2020
@hkang1 hkang1 merged commit 038e241 into determined-ai:master Aug 12, 2020
@hkang1 hkang1 deleted the 3817-fix-route-navigation branch August 12, 2020 18:51
@dannysauer dannysauer added this to the 0.13.0 milestone Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hamidzr hamidzr hamidzr approved these changes

@justin-determined-ai justin-determined-ai Awaiting requested review from justin-determined-ai

Assignees

@hkang1 hkang1

Labels
cla-signed
Projects
None yet
Milestone
0.13.0
Development

Successfully merging this pull request may close these issues.
4 participants
@hkang1 @justin-determined-ai @hamidzr @dannysauer