Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add proxy urls to tensorboards and notebooks [DET-3736] #1070

Merged
merged 4 commits into from
Aug 14, 2020

Conversation

hamidzr
Copy link
Member

@hamidzr hamidzr commented Aug 12, 2020

Description

add service_address to notebooks and tensorboards

Test Plan

Commentary (optional)

@cla-bot cla-bot bot added the cla-signed label Aug 12, 2020
@hamidzr hamidzr requested a review from sidneyw August 14, 2020 16:59
@hamidzr hamidzr marked this pull request as ready for review August 14, 2020 16:59
@hamidzr
Copy link
Member Author

hamidzr commented Aug 14, 2020

actually i found a better way. working on it.

@hamidzr hamidzr changed the title chore: add proxy urls to tensorboards and notebooks chore: add proxy urls to tensorboards and notebooks [DET-3736] Aug 14, 2020
@sidneyw sidneyw assigned hamidzr and unassigned sidneyw Aug 14, 2020
@hamidzr hamidzr merged commit 1b6c884 into determined-ai:master Aug 14, 2020
@hamidzr hamidzr deleted the 3736-proxy-urls branch August 14, 2020 21:31
stoksc pushed a commit that referenced this pull request Oct 17, 2023
wes-turner pushed a commit that referenced this pull request Feb 2, 2024
@dannysauer dannysauer added this to the 0.13.0 milestone Feb 6, 2024
eecsliu pushed a commit that referenced this pull request Apr 18, 2024
eecsliu pushed a commit to determined-ai/determined-release-testing that referenced this pull request Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants