Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: extract training validation metrics #1073

Merged
merged 2 commits into from
Aug 13, 2020

Conversation

hkang1
Copy link
Contributor

@hkang1 hkang1 commented Aug 12, 2020

Description

Set up types for training and validation metric names. Create utility function that extracts metric names from trial steps.

Test Plan

Commentary (optional)

@cla-bot cla-bot bot added the cla-signed label Aug 12, 2020
@hkang1 hkang1 changed the title Training validation metrics refactor: training validation metrics Aug 12, 2020
@hkang1 hkang1 changed the title refactor: training validation metrics chore: extract training validation metrics Aug 12, 2020
@hkang1 hkang1 requested a review from hamidzr August 12, 2020 22:58
Copy link
Member

@hamidzr hamidzr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for separating these

@hamidzr hamidzr assigned hkang1 and unassigned hamidzr Aug 13, 2020
@hkang1 hkang1 merged commit 701095e into determined-ai:master Aug 13, 2020
@hkang1 hkang1 deleted the training-validation-metrics branch August 13, 2020 17:39
@dannysauer dannysauer added this to the 0.13.0 milestone Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants