Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: only send slack messages for master branch CI #1077

Merged
merged 1 commit into from
Aug 13, 2020

Conversation

aaron276h
Copy link
Contributor

No description provided.

Copy link
Contributor

@stoksc stoksc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgmt, just a a question about the part that looks like a typo

@@ -1315,7 +1317,8 @@ workflows:
type: approval
filters: *upstream-feature-branch

- test-e2e-aws:
- test-e2e-aws
- :
Copy link
Contributor

@stoksc stoksc Aug 13, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this a typo? (circleci says..🤮) lol.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indeed it is

@stoksc stoksc assigned aaron276h and unassigned stoksc Aug 13, 2020
@stoksc
Copy link
Contributor

stoksc commented Aug 13, 2020

thanks for saving me from my shame. 🎊

@aaron276h aaron276h merged commit f939b1a into determined-ai:master Aug 13, 2020
stoksc pushed a commit that referenced this pull request Oct 17, 2023
…Pools method to include the custom resource pools. (#1077)
azhou-determined pushed a commit that referenced this pull request Dec 7, 2023
…Pools method to include the custom resource pools. (#1077)
wes-turner pushed a commit that referenced this pull request Feb 2, 2024
…Pools method to include the custom resource pools. (#1077)
@dannysauer dannysauer added this to the 0.13.0 milestone Feb 6, 2024
rb-determined-ai pushed a commit that referenced this pull request Feb 29, 2024
…Pools method to include the custom resource pools. (#1077)
amandavialva01 pushed a commit that referenced this pull request Mar 18, 2024
…Pools method to include the custom resource pools. (#1077)
eecsliu pushed a commit that referenced this pull request Apr 18, 2024
…Pools method to include the custom resource pools. (#1077)
eecsliu pushed a commit to determined-ai/determined-release-testing that referenced this pull request Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants