fix: handle failed checkpoints correctly [DET-3853] #1083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rb-determined-ai
approved these changes
Aug 13, 2020
| @@ -485,6 +485,16 @@ def test_fail_on_first_validation() -> None: | |||
| ) | |||
|
|
|||
|
|
|||
| @pytest.mark.e2e_cpu # type: ignore | |||
There was a problem hiding this comment.
Can we make this into a unit test rather than an e2e test? We already have some infrastructure in trial_workload_sequencer_test.go.
There was a problem hiding this comment.
What about both? In theory, this covers more than just the trial workload sequencer. This covers making sure this class of failures is handled by the entire system.
stoksc
changed the title
rb-determined-ai
approved these changes
Aug 13, 2020
azhou-determined
pushed a commit
that referenced
this pull request
Dec 7, 2023
wes-turner
pushed a commit
that referenced
this pull request
Feb 2, 2024
rb-determined-ai
pushed a commit
that referenced
this pull request
Feb 29, 2024
amandavialva01
pushed a commit
that referenced
this pull request
Mar 18, 2024
eecsliu
pushed a commit
that referenced
this pull request
Apr 18, 2024
eecsliu
pushed a commit
to determined-ai/determined-release-testing
that referenced
this pull request
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change fixes a bug in the trial workload sequencer were it is assumes that checkpoints won't fail. In the event of a failure checkpoint, a nil pointer is de-referenced when trying to access checkpoint metrics that don't exist in a failure.
Test Plan
Commentary (optional)