fix: record progress in partial units [DET-3869] #1091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change alters trials to report units completed as a
float64so that partial units can be reported correctly. Previously, if the searcher was configured in terms of epochs and anything less than an epoch was completed in a workload, the reported completedmodel.Lengthwas rounded to the nearest epoch; this usually ends up being 1 (except in the case of unusually small epochs or unusually large scheduling units) and makes progress appear completely wrong.Test Plan
Commentary
The weird thing about "add a unit test that checks searcher progress with records, batches and epochs" is that when an experiment completed we destroy the progress, so it seems impossible to write without being super flaky.