feat: improve shell cli for optional args [DET-3883] [DET-3886] #1098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dzhu
approved these changes
Aug 17, 2020
|
Also, commit/PR message: "BREKING" → "BREAKING". |
rb-determined-ai
force-pushed
the
shell-cli
branch
from
9a8c334
to
0654d60
Compare
BREAKING CHANGE: Change the format of the ssh options arguments to
`det shell start` and `det shell open`. Instead of calling:
det shell start --ssh-opt "-XY -o SomeOption='some string'"
which has multiple layers of quotes due to a two-step shell tokenizing,
now users should call:
det shell start -- -XY -o SomeOption="some string"
This change also allows us to clean up our internal implementation to
avoid relying on shell tokenization internally.
rb-determined-ai
changed the title
|
Also changing this PR to inject additional arguments after the ssh host when invoking ssh to solve DET-3886. As a result, |
rb-determined-ai
force-pushed
the
shell-cli
branch
from
0654d60
to
a492205
Compare
|
Looks good! |
rb-determined-ai
pushed a commit
that referenced
this pull request
Oct 27, 2023
* fix: update for error message change in product
rb-determined-ai
pushed a commit
that referenced
this pull request
Oct 31, 2023
* fix: update for error message change in product
rb-determined-ai
pushed a commit
that referenced
this pull request
Nov 2, 2023
* fix: update for error message change in product
rb-determined-ai
pushed a commit
that referenced
this pull request
Nov 2, 2023
* fix: update for error message change in product
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREKING CHANGE: Change the format of the ssh options arguments to
det shell startanddet shell open. Instead of calling:which has multiple layers of quotes due to a two-step shell tokenizing,
now users should call:
This change also allows us to clean up our internal implementation to
avoid relying on shell tokenization internally.