Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add README for new proposed release note process. #1113

Merged
merged 1 commit into from
Aug 19, 2020

Conversation

neilconway
Copy link
Contributor

@neilconway neilconway commented Aug 18, 2020

Description

Test Plan

Commentary (optional)

@cla-bot cla-bot bot added the cla-signed label Aug 18, 2020
@neilconway neilconway force-pushed the release-notes-readme branch 2 times, most recently from 55af911 to 4d60599 Compare August 18, 2020 18:24

* Write the release note entry as a separate file and add it to the
`docs/release-notes` directory. Name the file with the PR number as a
prefix. For example, `1097-nvidia-a100-support.txt`. The file should be in
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@hamidzr
Copy link
Member

hamidzr commented Aug 18, 2020

since github ui can render rst format. it might be also useful if these release notes were part the github PR template. some differences:

  • you can see how GitHub would render them easier
  • easier to tell what the PR is doing from POV of external "users".
  • easier to edit through the UI. harder/no-way to edit from your IDE
  • no version control
  • it changes how we pull the notes to stitch them together at release time

@neilconway
Copy link
Contributor Author

@hamidzr Yep, that would be another option. Why don't we try the proposed approach and see how it goes? We can discuss in eng-process whether folks want to try a different format/etc.

@hamidzr
Copy link
Member

hamidzr commented Aug 19, 2020

@hamidzr Yep, that would be another option. Why don't we try the proposed approach and see how it goes? We can discuss in eng-process whether folks want to try a different format/etc.

sounds good to me.

@@ -0,0 +1,43 @@
# Release Notes

We want release notes that are accurate, comprehensive, and written so that
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing a "to"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 hmm, where did you want the "to" added?

@neilconway neilconway merged commit 83e090f into determined-ai:master Aug 19, 2020
azhou-determined pushed a commit that referenced this pull request Dec 7, 2023
OIDC users can be auto-provisioned upon their first login.
wes-turner pushed a commit that referenced this pull request Feb 2, 2024
OIDC users can be auto-provisioned upon their first login.
@dannysauer dannysauer added this to the 0.13.2 milestone Feb 6, 2024
rb-determined-ai pushed a commit that referenced this pull request Feb 29, 2024
OIDC users can be auto-provisioned upon their first login.
amandavialva01 pushed a commit that referenced this pull request Mar 18, 2024
OIDC users can be auto-provisioned upon their first login.
eecsliu pushed a commit that referenced this pull request Apr 18, 2024
OIDC users can be auto-provisioned upon their first login.
eecsliu pushed a commit to determined-ai/determined-release-testing that referenced this pull request Apr 22, 2024
OIDC users can be auto-provisioned upon their first login.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants