-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Add README for new proposed release note process. #1113
chore: Add README for new proposed release note process. #1113
Conversation
55af911
to
4d60599
Compare
4d60599
to
98cc96b
Compare
|
||
* Write the release note entry as a separate file and add it to the | ||
`docs/release-notes` directory. Name the file with the PR number as a | ||
prefix. For example, `1097-nvidia-a100-support.txt`. The file should be in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
since github ui can render
|
@hamidzr Yep, that would be another option. Why don't we try the proposed approach and see how it goes? We can discuss in eng-process whether folks want to try a different format/etc. |
sounds good to me. |
@@ -0,0 +1,43 @@ | |||
# Release Notes | |||
|
|||
We want release notes that are accurate, comprehensive, and written so that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing a "to"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤔 hmm, where did you want the "to" added?
OIDC users can be auto-provisioned upon their first login.
OIDC users can be auto-provisioned upon their first login.
OIDC users can be auto-provisioned upon their first login.
OIDC users can be auto-provisioned upon their first login.
OIDC users can be auto-provisioned upon their first login.
OIDC users can be auto-provisioned upon their first login.
Description
Test Plan
Commentary (optional)