Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update examples doc #1123

Merged
merged 5 commits into from
Aug 20, 2020
Merged

Conversation

aaron276h
Copy link
Contributor

Description

Removed outdated code from examples, and added a couple FAQ items that have come up recently in the community slack.

Test Plan

Compiled locally.

@cla-bot cla-bot bot added the cla-signed label Aug 19, 2020
@aaron276h aaron276h changed the title docs: Update examples doc docs: update examples doc Aug 19, 2020
Copy link
Contributor

@neilconway neilconway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you for doing this!

As a reward for volunteering to do this, I have a few request for additional docs work below :) But lmk if you're busy and I can do it.

docs/faq.txt Outdated
<https://github.com/determined-ai/determined/blob/master/examples/experimental/trial/mnist_tp_to_estimator/model_def.py>`_.


Tensorboard Support
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"TensorBoard", here and below.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

docs/faq.txt Outdated
Tensorboard Support
-------------------

Can I log Tensorboards events in Determined?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a little confused by how this is worded: isn't all TensorBoard metadata captured as a series of events? Is this talking about logging additional custom data to TensorBoard? I wonder if a code example would be helpful -- i.e., where should the path /tmp/tensorboard be passed to?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I rephrased this and added a code snipped showing how this can be done for PyTorch.

docs/faq.txt Outdated

Can I use Tensorboard with PyTorch?
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Yes! For an example of this check out the `mnist-GAN example <https://github.com/determined-ai/determined/blob/master/examples/official/trial/mnist_gan_pytorch/model_def.py>`_.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind also updating the TensorBoard How-To guide with this information? A little more detail would be nice, as well -- i.e., is using determined.tensorboard.metric_writers.pytorch.TorchWriter necessary? (If so, maybe we should add that to the API reference -- but we can do that later.)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a bit more detail here, also added info about PyTorch to the How-To guide and a reference guide for determined.tensorboard.metric_writers.pytorch.TorchWriter.

@neilconway neilconway assigned aaron276h and unassigned neilconway Aug 19, 2020
@aaron276h aaron276h assigned neilconway and unassigned aaron276h Aug 20, 2020
Copy link
Contributor

@neilconway neilconway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks, @aaron276h !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants