fix: patch request body parsing for model metadata [DET-3939] #1144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sidneyw
changed the title
|
the swagger error seems to come from determined/proto/scripts/swagger.py Line 50 in a9d7007 update: yep this is it. |
hamidzr
reviewed
Aug 20, 2020
hamidzr
reviewed
Aug 20, 2020
| @@ -77,8 +77,6 @@ message PostModelResponse { | |||
| message PatchModelRequest { | |||
| // The model desired model fields and values. | |||
| determined.model.v1.Model model = 1; | |||
| // An update mask for the above model. | |||
There was a problem hiding this comment.
nit: can we remove the fieldmask import as well
|
This is the case #1144 (review). There is no way to differentiate between a user not sending the field and the user attempting to clear the field. |
I think we could separate the patch requests into multiple endpoints and that'd fix this but I'm not sure that's more ideal especially considering we're waiting on this for release. |
hamidzr
approved these changes
Aug 20, 2020
determined-dsw
pushed a commit
that referenced
this pull request
Aug 20, 2020
azhou-determined
pushed a commit
that referenced
this pull request
Dec 7, 2023
Make an error message for token invalidation more informative. It wraps the `jwt` error so that `errors.Is()` recognizes it down stream. The error message now reads "token is expired since it has been invalidated". (cherry picked from commit 3f80919fe224a6cec7e2fab526f660c888b0413d)
wes-turner
pushed a commit
that referenced
this pull request
Feb 2, 2024
Make an error message for token invalidation more informative. It wraps the `jwt` error so that `errors.Is()` recognizes it down stream. The error message now reads "token is expired since it has been invalidated".
rb-determined-ai
pushed a commit
that referenced
this pull request
Feb 29, 2024
Make an error message for token invalidation more informative. It wraps the `jwt` error so that `errors.Is()` recognizes it down stream. The error message now reads "token is expired since it has been invalidated".
amandavialva01
pushed a commit
that referenced
this pull request
Mar 18, 2024
Make an error message for token invalidation more informative. It wraps the `jwt` error so that `errors.Is()` recognizes it down stream. The error message now reads "token is expired since it has been invalidated".
eecsliu
pushed a commit
that referenced
this pull request
Apr 18, 2024
Make an error message for token invalidation more informative. It wraps the `jwt` error so that `errors.Is()` recognizes it down stream. The error message now reads "token is expired since it has been invalidated".
eecsliu
pushed a commit
to determined-ai/determined-release-testing
that referenced
this pull request
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It is unclear why this changed, however patch requests weren't parsing the request body. The update mask was automatically filled in though. I suspect something in the grpc reverse proxy is to blame but wasn't able to root cause this issue. This PR offers the same functionality as before but uses the
body: "*"request parsing.Test Plan
Adding a better E2E test as a follow on.
Commentary (optional)