feat: has validation filter [DET-3962] #1171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hkang1
force-pushed
the
3962-has-validation-filter
branch
from
53cdf6a
to
94bd081
Compare
hamidzr
reviewed
Aug 27, 2020
hkang1
force-pushed
the
3962-has-validation-filter
branch
2 times, most recently
from
04c1137
to
1352d52
Compare
hamidzr
reviewed
Aug 31, 2020
added 7 commits
August 31, 2020 20:09
hkang1
force-pushed
the
3962-has-validation-filter
branch
from
47036e0
to
25e109d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
UPDATE
After discussion with @vishnu2kmohan. Decided it's best to separate out the controls for
Has CheckpointandHas Validation. The select dropdown works to enable each filter independently or have the joint behavior to be anOR(opposed to the default and assumedANDbehavior).Update the
Has Checkpointfilter on the trial details table toHas Checkpoint Or Validationfilter. If the trial batches has a checkpoint or a validation, it will show up when the filter toggle is enabled.Add the ability save filter states to user preferences. The
Has Checkpoint Or Validationwill get applied across all trial detail pages, while theMetricsfilter save on a per unique experiment trial. If the user selects metrics X, Y and Z on trial 1 of experiment 1, when they visit trial 5 of experiment 1, the metrics X, Y and Z will be selected by default.Test Plan
Commentary (optional)
Checklist
docs/release-notes/.See Release Note for details.