Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: apply filter limit to dashboard [DET-3973] #1172

Merged
merged 2 commits into from
Aug 27, 2020
Merged

fix: apply filter limit to dashboard [DET-3973] #1172

merged 2 commits into from
Aug 27, 2020

Conversation

hkang1
Copy link
Contributor

@hkang1 hkang1 commented Aug 26, 2020 •
edited
Loading

Description

BUG FIX

  • Reapply the filtering for just the dashboard recent tasks. The limit filter was previously removed from the experiment and task list since they naturally get filtered through pagination. This affected the dashboard limit filtering, since it still relied on the filtering.

Test Plan

Screen Shot 2020-08-26 at 9 50 45 AM

Commentary (optional)

Checklist

  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.

@cla-bot cla-bot bot added the cla-signed label Aug 26, 2020
vishnu2kmohan
vishnu2kmohan approved these changes Aug 26, 2020
View reviewed changes
Copy link
Contributor

@vishnu2kmohan vishnu2kmohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix @hkang1.

Approved modulo @armandmcqueen's review.

@hkang1 hkang1 requested review from justin-determined-ai and removed request for armandmcqueen August 27, 2020 19:03
justin-determined-ai
justin-determined-ai approved these changes Aug 27, 2020
View reviewed changes
Copy link
Contributor

@justin-determined-ai justin-determined-ai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One blocking change but LGTM!

docs/release-notes/1172-fix-dashboard-limit.txt Outdated Show resolved Hide resolved
@hkang1 hkang1 merged commit 939b57e into determined-ai:master Aug 27, 2020
@hkang1 hkang1 deleted the 3973-fix-dashboard-limit branch August 27, 2020 21:04
wes-turner pushed a commit that referenced this pull request Feb 2, 2024
@salonig23 @determined-ci
feat: add scope for pach_d integration in OIDC (#1172)
f5c4223
@dannysauer dannysauer added this to the 0.13.2 milestone Feb 6, 2024
rb-determined-ai pushed a commit that referenced this pull request Feb 29, 2024
@salonig23 @djanicekpach
feat: add scope for pach_d integration in OIDC (#1172)
01f5364
amandavialva01 pushed a commit that referenced this pull request Mar 18, 2024
@salonig23 @determined-ci
feat: add scope for pach_d integration in OIDC (#1172)
6857d72
eecsliu pushed a commit that referenced this pull request Apr 18, 2024
@salonig23 @determined-ci
feat: add scope for pach_d integration in OIDC (#1172)
6c1137e
eecsliu pushed a commit to determined-ai/determined-release-testing that referenced this pull request Apr 22, 2024
@salonig23 @eecsliu
feat: add scope for pach_d integration in OIDC (determined-ai#1172)
e41f54b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justin-determined-ai justin-determined-ai justin-determined-ai approved these changes

@vishnu2kmohan vishnu2kmohan vishnu2kmohan approved these changes

Assignees

@hkang1 hkang1

Labels
cla-signed
Projects
None yet
Milestone
0.13.2
Development

Successfully merging this pull request may close these issues.
5 participants
@hkang1 @vishnu2kmohan @justin-determined-ai @dannysauer @armandmcqueen