style: add more React focused linting #1178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hkang1
commented
Aug 26, 2020
| @@ -50,10 +51,18 @@ module.exports = { | |||
| 'no-multi-spaces': [ 'error', { ignoreEOLComments: true } ], | |||
| 'no-multiple-empty-lines': [ 'error', { max: 1, maxBOF: 0, maxEOF: 0 } ], | |||
| 'no-trailing-spaces': [ 'error', {} ], | |||
| 'object-curly-newline': [ 'error', { | |||
| ExportDeclaration: { consistent: true }, | |||
There was a problem hiding this comment.
changed this to consistent instead of multiline for import and export so we can still support something like this:
import {
Checkpoint, CheckpointDetail, CheckpointState, ExperimentDetails,
RunState, Step, TrialDetails, ValidationMetrics,
} from 'types';
otherwise each of those imports will be on its own line
hamidzr
approved these changes
Aug 27, 2020
The |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add the following rules:
object-curly-newlinereact/jsx-first-prop-new-linereact/jsx-max-props-per-lineThe JSX rules will help us add fixable structuring to our JSX.
Test Plan
Commentary (optional)
Checklist
docs/release-notes/.See Release Note for details.