Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: dump master logs after webui tests #1205

Merged
merged 1 commit into from
Aug 31, 2020
Merged

ci: dump master logs after webui tests #1205

merged 1 commit into from
Aug 31, 2020

Conversation

rb-determined-ai
Copy link
Member

No description provided.

@cla-bot cla-bot bot added the cla-signed label Aug 29, 2020
stoksc
stoksc approved these changes Aug 31, 2020
View reviewed changes
Copy link
Contributor

@stoksc stoksc left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. we'll have them twice in some cases, but that's fine. I think it's better to do this by just telling it (CI) to run docker-compose logs than rerolling that subprocess/docker-compose function here too.

@stoksc stoksc assigned rb-determined-ai and unassigned stoksc Aug 31, 2020
@rb-determined-ai
Copy link
Member Author

we'll have them twice in some cases

Wait, under which cases will we have them twice? To me this looks like it will only print logs after the webui tests run, and I did not see another way that they would print in that case

@stoksc
Copy link
Contributor

stoksc commented Aug 31, 2020

@rb-determined-ai ah duh, this is for webui tests that docker-compose and detach. ok only once.

@rb-determined-ai rb-determined-ai merged commit cbb8943 into determined-ai:master Aug 31, 2020
@rb-determined-ai rb-determined-ai deleted the webui-master-logs branch August 31, 2020 17:58
@dannysauer dannysauer added this to the 0.13.2 milestone Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stoksc stoksc stoksc approved these changes

Assignees

@rb-determined-ai rb-determined-ai

Labels
cla-signed
Projects
None yet
Milestone
0.13.2
Development

Successfully merging this pull request may close these issues.
3 participants
@rb-determined-ai @stoksc @dannysauer