-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: migrate experiment list api [DET-3696, DET-3697, DET-3698] #1228
chore: migrate experiment list api [DET-3696, DET-3697, DET-3698] #1228
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work putting this together so quickly! I think it looks good, with a few questions I was unsure of.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for getting this out quickly! I added comments going through the code. I still need to do a visual check. WIP
@@ -260,6 +262,47 @@ export const jsonToTrialDetails = (data: unknown): TrialDetails => { | |||
}; | |||
}; | |||
|
|||
const experimentStateMap = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for later: we'll have a bunch of these I think we could start mapping them in a separate file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and maybe the mapping functions below for state as they're used elsewhere
most of the comments are on type and code structure so I think we could leave a big chunk of it for later if we need to get pagination in quickly. visually testing it now |
dee760e
to
bbd3c50
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
bbd3c50
to
a3cf629
Compare
Description
We hit a wall with large experiment lists with the old API earlier than anticipated. Migrate over to the new API for experiment list to introduce pagination to break up the massive experiment list. UI should remain the same, except the pagination interactions triggers additional paginated calls to the API.
Test Plan
Commentary (optional)
Checklist
docs/release-notes/
.See Release Note for details.