feat: break workload info from trial endpoint into a new endpoint [DET-6729] #3635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for determined-ui canceled.
|
|
cc @stoksc because I have less context on this |
stoksc
reviewed
Feb 24, 2022
| rpc GetTrialWorkloads(GetTrialWorkloadsRequest) | ||
| returns (GetTrialWorkloadsResponse) { | ||
| option (google.api.http) = { | ||
| get: "/api/v1/trial/{trial_id}/workloads" |
There was a problem hiding this comment.
post discussion in backend eng, should we just make the the /metrics endpoint?
dzhu
force-pushed
the
trial-workloads-api
branch
2 times, most recently
from
f2e3ac9
to
dd39c93
Compare
|
@dzhu this step probably comes at the end, but should the changes generated by the following get checked in also? |
hkang1
reviewed
Mar 2, 2022
| @@ -84,6 +84,8 @@ message Trial { | |||
| // The wall clock time is all active time of the cluster for the trial, | |||
| // inclusive of everything (restarts, initiailization, etc), in seconds. | |||
| double wall_clock_time = 12; | |||
| // The sum of sizes of all resources in all checkpoints for the trial. | |||
| uint64 total_checkpoint_size = 13; | |||
There was a problem hiding this comment.
question: I see this defined here as uint64 but the endpoint returns this as a string for some reason:
Codecov Report
@@ Coverage Diff @@
## master #3635 +/- ##
=======================================
Coverage 24.62% 24.62%
=======================================
Files 256 256
Lines 9982 9982
Branches 2818 2818
=======================================
Hits 2458 2458
Misses 7507 7507
Partials 17 17 📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
dzhu
force-pushed
the
trial-workloads-api
branch
4 times, most recently
from
d80a7c1
to
ce1fe9b
Compare
When a trial has run many workloads, the response to the trial details endpoint for it can become very large and unwieldy. Since we don't always need the full set of workloads, we move those into a new endpoint and just have some useful workload summary information in the original one.
Closed
3 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When a trial has run many workloads, the response to the trial details
endpoint for it can become very large and unwieldy. Since we don't
always need the full set of workloads, we move those into a new endpoint
and just have some useful workload summary information in the original
one.
Test Plan
Commentary
First two bullet points from the ticket done, third still to do.
The total checkpoint size is represented in the protobuf as uint64, since a trial with large or many checkpoints could easily overflow 32 bits. That ends up being translated into JSON as a string because JavaScript can't natively represent all 64-bit integers. The only alternative appears to be switching the type to float, which would feel weird to me.