test: remove WebUI e2e-tests dependency on det-deploy #575
Conversation
hamidzr
force-pushed
the
3072-webui-remove-det-deploy
branch
from
69e2b8c
to
b23fd92
Compare
hamidzr
force-pushed
the
3072-webui-remove-det-deploy
branch
from
b23fd92
to
2636e19
Compare
There was a problem hiding this comment.
Sooooooo much faster than docker image build 👍 👍 👍
I added some comments, but there was a question regarding $PROJECT_ROOT. I don't have that defined and can't find any references to it. My equivalent is $DET_PROJ but that might be specific to my setup. The relative path approach (how the original Makefile had it) makes more sense so it doesn't rely on an env var.
| ) | ||
|
|
||
| return subprocess.run( | ||
| f"seq {count} | xargs -n 1 -P 0 -I[] {cmd}", shell=True, check=True, |
There was a problem hiding this comment.
can you test that this works on mac? @hkang1
There was a problem hiding this comment.
@hamidzr For this part I encounter this error:
no matches found: -I[]
It didn't like the -I[] option...
There was a problem hiding this comment.
swapped it for a python solution.
push users toward directly iterating with the python script to benefit from the cli support
hamidzr
force-pushed
the
3072-webui-remove-det-deploy
branch
from
fdcee5c
to
669c4cc
Compare
|
e2e-tests got stuck on cancelling an experiment: video |
For me it only failed locally on But |
based on the UI I think you are using build files from another branch :) |
Description
This PR removes the webui e2e tests dependency on
det-deployand improves developer interactions with the test runnere2e-tests.pyhttps://determinedai.atlassian.net/browse/DET-3072
https://determinedai.atlassian.net/browse/DET-2652
Test Plan
Ran tests locally and got all greens.
Commentary (optional)
left 1004ef8 as a direct copy of the
toolsdirectory so that part probably doesn't need a review.