fix: handle auth check cancelation #710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tayritenour
pushed a commit
to tayritenour/determined
that referenced
this pull request
Apr 25, 2023
…2] (determined-ai#710) Singularity/Enroot do not support overlapping mounts. Allowing a user mount under /run/determined conflicts with generated mounts, so fail such attempts with a clean error message.
eecsliu
pushed a commit
to eecsliu/determined
that referenced
this pull request
Jun 23, 2023
…2] (determined-ai#710) Singularity/Enroot do not support overlapping mounts. Allowing a user mount under /run/determined conflicts with generated mounts, so fail such attempts with a clean error message.
stoksc
pushed a commit
that referenced
this pull request
Jun 26, 2023
…2] (#710) Singularity/Enroot do not support overlapping mounts. Allowing a user mount under /run/determined conflicts with generated mounts, so fail such attempts with a clean error message.
eecsliu
pushed a commit
that referenced
this pull request
Jun 28, 2023
…2] (#710) Singularity/Enroot do not support overlapping mounts. Allowing a user mount under /run/determined conflicts with generated mounts, so fail such attempts with a clean error message.
eecsliu
pushed a commit
that referenced
this pull request
Jun 28, 2023
…2] (#710) Singularity/Enroot do not support overlapping mounts. Allowing a user mount under /run/determined conflicts with generated mounts, so fail such attempts with a clean error message.
stoksc
pushed a commit
that referenced
this pull request
Jul 20, 2023
…2] (#710) Singularity/Enroot do not support overlapping mounts. Allowing a user mount under /run/determined conflicts with generated mounts, so fail such attempts with a clean error message.
eecsliu
pushed a commit
that referenced
this pull request
Jul 24, 2023
…2] (#710) Singularity/Enroot do not support overlapping mounts. Allowing a user mount under /run/determined conflicts with generated mounts, so fail such attempts with a clean error message.
rb-determined-ai
pushed a commit
that referenced
this pull request
Oct 5, 2023
…2] (#710) Singularity/Enroot do not support overlapping mounts. Allowing a user mount under /run/determined conflicts with generated mounts, so fail such attempts with a clean error message. [e2e_tests changes only]
rb-determined-ai
pushed a commit
that referenced
this pull request
Oct 10, 2023
…2] (#710) Singularity/Enroot do not support overlapping mounts. Allowing a user mount under /run/determined conflicts with generated mounts, so fail such attempts with a clean error message. [e2e_tests changes only]
stoksc
pushed a commit
that referenced
this pull request
Oct 17, 2023
…2] (#710) Singularity/Enroot do not support overlapping mounts. Allowing a user mount under /run/determined conflicts with generated mounts, so fail such attempts with a clean error message.
rb-determined-ai
pushed a commit
that referenced
this pull request
Oct 27, 2023
…2] (#710) Singularity/Enroot do not support overlapping mounts. Allowing a user mount under /run/determined conflicts with generated mounts, so fail such attempts with a clean error message. [e2e_tests changes only]
rb-determined-ai
pushed a commit
that referenced
this pull request
Oct 31, 2023
…2] (#710) Singularity/Enroot do not support overlapping mounts. Allowing a user mount under /run/determined conflicts with generated mounts, so fail such attempts with a clean error message. [e2e_tests changes only]
rb-determined-ai
pushed a commit
that referenced
this pull request
Nov 2, 2023
…2] (#710) Singularity/Enroot do not support overlapping mounts. Allowing a user mount under /run/determined conflicts with generated mounts, so fail such attempts with a clean error message. [e2e_tests changes only]
rb-determined-ai
pushed a commit
that referenced
this pull request
Nov 2, 2023
…2] (#710) Singularity/Enroot do not support overlapping mounts. Allowing a user mount under /run/determined conflicts with generated mounts, so fail such attempts with a clean error message. [e2e_tests changes only]
azhou-determined
pushed a commit
that referenced
this pull request
Dec 7, 2023
…2] (#710) Singularity/Enroot do not support overlapping mounts. Allowing a user mount under /run/determined conflicts with generated mounts, so fail such attempts with a clean error message. [excluding e2e_tests changes]
wes-turner
pushed a commit
that referenced
this pull request
Feb 2, 2024
…2] (#710) Singularity/Enroot do not support overlapping mounts. Allowing a user mount under /run/determined conflicts with generated mounts, so fail such attempts with a clean error message. [excluding e2e_tests changes]
rb-determined-ai
pushed a commit
that referenced
this pull request
Feb 29, 2024
…2] (#710) Singularity/Enroot do not support overlapping mounts. Allowing a user mount under /run/determined conflicts with generated mounts, so fail such attempts with a clean error message. [excluding e2e_tests changes]
amandavialva01
pushed a commit
that referenced
this pull request
Mar 18, 2024
…2] (#710) Singularity/Enroot do not support overlapping mounts. Allowing a user mount under /run/determined conflicts with generated mounts, so fail such attempts with a clean error message. [excluding e2e_tests changes]
eecsliu
pushed a commit
that referenced
this pull request
Apr 18, 2024
…2] (#710) Singularity/Enroot do not support overlapping mounts. Allowing a user mount under /run/determined conflicts with generated mounts, so fail such attempts with a clean error message. [excluding e2e_tests changes]
eecsliu
pushed a commit
to determined-ai/determined-release-testing
that referenced
this pull request
Apr 22, 2024
…2] (determined-ai#710) Singularity/Enroot do not support overlapping mounts. Allowing a user mount under /run/determined conflicts with generated mounts, so fail such attempts with a clean error message. [excluding e2e_tests changes]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
During
webui-e2e-tests, there is sometimes a race condition during login check that cancels user authentication check. The cancelation of the auth check causes the webui to clear out the cookie and log you out because it is considered an auth failure. Instead, we need to handle cancelation to skip the clearing of the cookies.Test Plan
Pay special attention to CI
webui-e2e-teststo see if failure occurs on the 5th test of the02-loginout.spec.tstest suite (should redirect away from login when visiting login while logged in). This test should not fail due to aborted/users/mecalls.Commentary (optional)