fix: learning rate scheduler fix for bert squad example [DET-2897] #711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davetroiano
commented
Jun 15, 2020
| max_seq_length: 384 | ||
| doc_stride: 128 | ||
| max_query_length: 64 | ||
| n_best_size: 20 | ||
| max_answer_length: 30 | ||
| null_score_diff_threshold: 0.0 | ||
| max_grad_norm: 1.0 | ||
| num_training_steps: 15000 # This is the number of optimizer steps. Set it |
There was a problem hiding this comment.
this is the main fix to achieve parity. if this value is too low, we end up with a LR of zero pretty quickly, and this was causing the learning to basically stop (validation f1 flatlined at 60-something).
in the huggingface repo, they set this similarly to # batches times * epochs (assuming gradient accumulation is 1) -- see here and here.
with this fix we get closer to the expected validation f1: 89 after 150 steps, compared to 88.52.
|
output from a const run:
|
naren-determined
approved these changes
Jun 15, 2020
tayritenour
pushed a commit
to tayritenour/determined
that referenced
this pull request
Apr 25, 2023
If the Slrum hpcPartitionDetails contains accelerator type set it for the resource pool.
eecsliu
pushed a commit
to eecsliu/determined
that referenced
this pull request
Jun 23, 2023
If the Slrum hpcPartitionDetails contains accelerator type set it for the resource pool.
stoksc
pushed a commit
that referenced
this pull request
Jun 26, 2023
If the Slrum hpcPartitionDetails contains accelerator type set it for the resource pool.
eecsliu
pushed a commit
that referenced
this pull request
Jun 28, 2023
If the Slrum hpcPartitionDetails contains accelerator type set it for the resource pool.
eecsliu
pushed a commit
that referenced
this pull request
Jun 28, 2023
If the Slrum hpcPartitionDetails contains accelerator type set it for the resource pool.
stoksc
pushed a commit
that referenced
this pull request
Jul 20, 2023
If the Slrum hpcPartitionDetails contains accelerator type set it for the resource pool.
eecsliu
pushed a commit
that referenced
this pull request
Jul 24, 2023
If the Slrum hpcPartitionDetails contains accelerator type set it for the resource pool.
stoksc
pushed a commit
that referenced
this pull request
Oct 17, 2023
If the Slrum hpcPartitionDetails contains accelerator type set it for the resource pool.
azhou-determined
pushed a commit
that referenced
this pull request
Dec 7, 2023
If the Slrum hpcPartitionDetails contains accelerator type set it for the resource pool.
wes-turner
pushed a commit
that referenced
this pull request
Feb 2, 2024
If the Slrum hpcPartitionDetails contains accelerator type set it for the resource pool.
rb-determined-ai
pushed a commit
that referenced
this pull request
Feb 29, 2024
If the Slrum hpcPartitionDetails contains accelerator type set it for the resource pool.
amandavialva01
pushed a commit
that referenced
this pull request
Mar 18, 2024
If the Slrum hpcPartitionDetails contains accelerator type set it for the resource pool.
eecsliu
pushed a commit
that referenced
this pull request
Apr 18, 2024
If the Slrum hpcPartitionDetails contains accelerator type set it for the resource pool.
eecsliu
pushed a commit
to determined-ai/determined-release-testing
that referenced
this pull request
Apr 22, 2024
If the Slrum hpcPartitionDetails contains accelerator type set it for the resource pool.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Test Plan
Commentary (optional)