-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add support for model.stop_training to Keras docstring #714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaron276h
approved these changes
Jun 15, 2020
tayritenour
pushed a commit
to tayritenour/determined
that referenced
this pull request
Apr 25, 2023
determined-ai#714) The _test_master_restart_cmd tests are failing when run as part of the e2e_slurm_restart job inside the nightly workflow. The reason they are failing is that these tests pull an image as part of the test which takes more than a couple of minutes. This delay makes the experiment stay in PULLING state instead of RUNNING state and makes the check for RUNNING status inside _test_master_restart_cmd fail. I increased the timeout from 30 seconds to 300 seconds and tested the e2e_slurm_restart job manually to ensure all the tests run successfully.
eecsliu
pushed a commit
to eecsliu/determined
that referenced
this pull request
Jun 23, 2023
determined-ai#714) The _test_master_restart_cmd tests are failing when run as part of the e2e_slurm_restart job inside the nightly workflow. The reason they are failing is that these tests pull an image as part of the test which takes more than a couple of minutes. This delay makes the experiment stay in PULLING state instead of RUNNING state and makes the check for RUNNING status inside _test_master_restart_cmd fail. I increased the timeout from 30 seconds to 300 seconds and tested the e2e_slurm_restart job manually to ensure all the tests run successfully.
stoksc
pushed a commit
that referenced
this pull request
Jun 26, 2023
#714) The _test_master_restart_cmd tests are failing when run as part of the e2e_slurm_restart job inside the nightly workflow. The reason they are failing is that these tests pull an image as part of the test which takes more than a couple of minutes. This delay makes the experiment stay in PULLING state instead of RUNNING state and makes the check for RUNNING status inside _test_master_restart_cmd fail. I increased the timeout from 30 seconds to 300 seconds and tested the e2e_slurm_restart job manually to ensure all the tests run successfully.
eecsliu
pushed a commit
that referenced
this pull request
Jun 28, 2023
#714) The _test_master_restart_cmd tests are failing when run as part of the e2e_slurm_restart job inside the nightly workflow. The reason they are failing is that these tests pull an image as part of the test which takes more than a couple of minutes. This delay makes the experiment stay in PULLING state instead of RUNNING state and makes the check for RUNNING status inside _test_master_restart_cmd fail. I increased the timeout from 30 seconds to 300 seconds and tested the e2e_slurm_restart job manually to ensure all the tests run successfully.
eecsliu
pushed a commit
that referenced
this pull request
Jun 28, 2023
#714) The _test_master_restart_cmd tests are failing when run as part of the e2e_slurm_restart job inside the nightly workflow. The reason they are failing is that these tests pull an image as part of the test which takes more than a couple of minutes. This delay makes the experiment stay in PULLING state instead of RUNNING state and makes the check for RUNNING status inside _test_master_restart_cmd fail. I increased the timeout from 30 seconds to 300 seconds and tested the e2e_slurm_restart job manually to ensure all the tests run successfully.
stoksc
pushed a commit
that referenced
this pull request
Jul 20, 2023
#714) The _test_master_restart_cmd tests are failing when run as part of the e2e_slurm_restart job inside the nightly workflow. The reason they are failing is that these tests pull an image as part of the test which takes more than a couple of minutes. This delay makes the experiment stay in PULLING state instead of RUNNING state and makes the check for RUNNING status inside _test_master_restart_cmd fail. I increased the timeout from 30 seconds to 300 seconds and tested the e2e_slurm_restart job manually to ensure all the tests run successfully.
eecsliu
pushed a commit
that referenced
this pull request
Jul 24, 2023
#714) The _test_master_restart_cmd tests are failing when run as part of the e2e_slurm_restart job inside the nightly workflow. The reason they are failing is that these tests pull an image as part of the test which takes more than a couple of minutes. This delay makes the experiment stay in PULLING state instead of RUNNING state and makes the check for RUNNING status inside _test_master_restart_cmd fail. I increased the timeout from 30 seconds to 300 seconds and tested the e2e_slurm_restart job manually to ensure all the tests run successfully.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Test Plan
Commentary (optional)