style: fix task card, menu and dropdown styles to be uniform [DET-3286] #723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hkang1
changed the title
hamidzr
approved these changes
Jun 17, 2020
| @@ -51,23 +51,12 @@ const TaskActionDropdown: React.FC<Props> = ({ task }: Props) => { | |||
| params.domEvent.stopPropagation(); | |||
| try { | |||
| switch (params.key) { // Cases should match menu items. | |||
| case 'kill': | |||
There was a problem hiding this comment.
suggestion: avoid moving the switch cases around to preserve history if there is no real change happening.
There was a problem hiding this comment.
I assume the move is to keep the order the same as the menu items?
tayritenour
pushed a commit
to tayritenour/determined
that referenced
this pull request
Apr 25, 2023
…arts of slurm jobs. (FOUNDENG-495) (determined-ai#723) [FOUNDENG-453](https://jira-pro.its.hpecorp.net:8443/browse/FOUNDENG-453) [PR](https://github.hpe.com/hpe/hpc-ard-capsules-core/pull/765) sets the `--no-requeue` option for SLURM by default in the launcher code. Ideally, this should come from determined as this is the default enforced by determined not the launcher. Added code to determined to pass the `--no-requeue` option to the launcher. Please note that the changes in the launcher code will be reverted as part of the future issue [FOUNDENG-496](https://jira-pro.its.hpecorp.net:8443/browse/FOUNDENG-496). Also, the documentation changes for this issue can be found at determined-ai#6141.
tayritenour
pushed a commit
to tayritenour/determined
that referenced
this pull request
Apr 25, 2023
chore: Revert changes in determined-ai#723 (determined-ai#744)
eecsliu
pushed a commit
to eecsliu/determined
that referenced
this pull request
Jun 23, 2023
…arts of slurm jobs. (FOUNDENG-495) (determined-ai#723) [FOUNDENG-453](https://jira-pro.its.hpecorp.net:8443/browse/FOUNDENG-453) [PR](https://github.hpe.com/hpe/hpc-ard-capsules-core/pull/765) sets the `--no-requeue` option for SLURM by default in the launcher code. Ideally, this should come from determined as this is the default enforced by determined not the launcher. Added code to determined to pass the `--no-requeue` option to the launcher. Please note that the changes in the launcher code will be reverted as part of the future issue [FOUNDENG-496](https://jira-pro.its.hpecorp.net:8443/browse/FOUNDENG-496). Also, the documentation changes for this issue can be found at determined-ai#6141.
eecsliu
pushed a commit
to eecsliu/determined
that referenced
this pull request
Jun 23, 2023
stoksc
pushed a commit
that referenced
this pull request
Jun 26, 2023
…arts of slurm jobs. (FOUNDENG-495) (#723) [FOUNDENG-453](https://jira-pro.its.hpecorp.net:8443/browse/FOUNDENG-453) [PR](https://github.hpe.com/hpe/hpc-ard-capsules-core/pull/765) sets the `--no-requeue` option for SLURM by default in the launcher code. Ideally, this should come from determined as this is the default enforced by determined not the launcher. Added code to determined to pass the `--no-requeue` option to the launcher. Please note that the changes in the launcher code will be reverted as part of the future issue [FOUNDENG-496](https://jira-pro.its.hpecorp.net:8443/browse/FOUNDENG-496). Also, the documentation changes for this issue can be found at #6141.
stoksc
pushed a commit
that referenced
this pull request
Jun 26, 2023
eecsliu
pushed a commit
that referenced
this pull request
Jun 28, 2023
…arts of slurm jobs. (FOUNDENG-495) (#723) [FOUNDENG-453](https://jira-pro.its.hpecorp.net:8443/browse/FOUNDENG-453) [PR](https://github.hpe.com/hpe/hpc-ard-capsules-core/pull/765) sets the `--no-requeue` option for SLURM by default in the launcher code. Ideally, this should come from determined as this is the default enforced by determined not the launcher. Added code to determined to pass the `--no-requeue` option to the launcher. Please note that the changes in the launcher code will be reverted as part of the future issue [FOUNDENG-496](https://jira-pro.its.hpecorp.net:8443/browse/FOUNDENG-496). Also, the documentation changes for this issue can be found at #6141.
eecsliu
pushed a commit
that referenced
this pull request
Jun 28, 2023
eecsliu
pushed a commit
that referenced
this pull request
Jun 28, 2023
…arts of slurm jobs. (FOUNDENG-495) (#723) [FOUNDENG-453](https://jira-pro.its.hpecorp.net:8443/browse/FOUNDENG-453) [PR](https://github.hpe.com/hpe/hpc-ard-capsules-core/pull/765) sets the `--no-requeue` option for SLURM by default in the launcher code. Ideally, this should come from determined as this is the default enforced by determined not the launcher. Added code to determined to pass the `--no-requeue` option to the launcher. Please note that the changes in the launcher code will be reverted as part of the future issue [FOUNDENG-496](https://jira-pro.its.hpecorp.net:8443/browse/FOUNDENG-496). Also, the documentation changes for this issue can be found at #6141.
eecsliu
pushed a commit
that referenced
this pull request
Jun 28, 2023
stoksc
pushed a commit
that referenced
this pull request
Jul 20, 2023
…arts of slurm jobs. (FOUNDENG-495) (#723) [FOUNDENG-453](https://jira-pro.its.hpecorp.net:8443/browse/FOUNDENG-453) [PR](https://github.hpe.com/hpe/hpc-ard-capsules-core/pull/765) sets the `--no-requeue` option for SLURM by default in the launcher code. Ideally, this should come from determined as this is the default enforced by determined not the launcher. Added code to determined to pass the `--no-requeue` option to the launcher. Please note that the changes in the launcher code will be reverted as part of the future issue [FOUNDENG-496](https://jira-pro.its.hpecorp.net:8443/browse/FOUNDENG-496). Also, the documentation changes for this issue can be found at #6141.
stoksc
pushed a commit
that referenced
this pull request
Jul 20, 2023
eecsliu
pushed a commit
that referenced
this pull request
Jul 24, 2023
…arts of slurm jobs. (FOUNDENG-495) (#723) [FOUNDENG-453](https://jira-pro.its.hpecorp.net:8443/browse/FOUNDENG-453) [PR](https://github.hpe.com/hpe/hpc-ard-capsules-core/pull/765) sets the `--no-requeue` option for SLURM by default in the launcher code. Ideally, this should come from determined as this is the default enforced by determined not the launcher. Added code to determined to pass the `--no-requeue` option to the launcher. Please note that the changes in the launcher code will be reverted as part of the future issue [FOUNDENG-496](https://jira-pro.its.hpecorp.net:8443/browse/FOUNDENG-496). Also, the documentation changes for this issue can be found at #6141.
eecsliu
pushed a commit
that referenced
this pull request
Jul 24, 2023
stoksc
pushed a commit
that referenced
this pull request
Oct 17, 2023
…arts of slurm jobs. (FOUNDENG-495) (#723) [FOUNDENG-453](https://jira-pro.its.hpecorp.net:8443/browse/FOUNDENG-453) [PR](https://github.hpe.com/hpe/hpc-ard-capsules-core/pull/765) sets the `--no-requeue` option for SLURM by default in the launcher code. Ideally, this should come from determined as this is the default enforced by determined not the launcher. Added code to determined to pass the `--no-requeue` option to the launcher. Please note that the changes in the launcher code will be reverted as part of the future issue [FOUNDENG-496](https://jira-pro.its.hpecorp.net:8443/browse/FOUNDENG-496). Also, the documentation changes for this issue can be found at #6141.
stoksc
pushed a commit
that referenced
this pull request
Oct 17, 2023
azhou-determined
pushed a commit
that referenced
this pull request
Dec 7, 2023
…arts of slurm jobs. (FOUNDENG-495) (#723) [FOUNDENG-453](https://jira-pro.its.hpecorp.net:8443/browse/FOUNDENG-453) [PR](https://github.hpe.com/hpe/hpc-ard-capsules-core/pull/765) sets the `--no-requeue` option for SLURM by default in the launcher code. Ideally, this should come from determined as this is the default enforced by determined not the launcher. Added code to determined to pass the `--no-requeue` option to the launcher. Please note that the changes in the launcher code will be reverted as part of the future issue [FOUNDENG-496](https://jira-pro.its.hpecorp.net:8443/browse/FOUNDENG-496). Also, the documentation changes for this issue can be found at #6141.
azhou-determined
pushed a commit
that referenced
this pull request
Dec 7, 2023
wes-turner
pushed a commit
that referenced
this pull request
Feb 2, 2024
…arts of slurm jobs. (FOUNDENG-495) (#723) [FOUNDENG-453](https://jira-pro.its.hpecorp.net:8443/browse/FOUNDENG-453) [PR](https://github.hpe.com/hpe/hpc-ard-capsules-core/pull/765) sets the `--no-requeue` option for SLURM by default in the launcher code. Ideally, this should come from determined as this is the default enforced by determined not the launcher. Added code to determined to pass the `--no-requeue` option to the launcher. Please note that the changes in the launcher code will be reverted as part of the future issue [FOUNDENG-496](https://jira-pro.its.hpecorp.net:8443/browse/FOUNDENG-496). Also, the documentation changes for this issue can be found at #6141.
wes-turner
pushed a commit
that referenced
this pull request
Feb 2, 2024
rb-determined-ai
pushed a commit
that referenced
this pull request
Feb 29, 2024
…arts of slurm jobs. (FOUNDENG-495) (#723) [FOUNDENG-453](https://jira-pro.its.hpecorp.net:8443/browse/FOUNDENG-453) [PR](https://github.hpe.com/hpe/hpc-ard-capsules-core/pull/765) sets the `--no-requeue` option for SLURM by default in the launcher code. Ideally, this should come from determined as this is the default enforced by determined not the launcher. Added code to determined to pass the `--no-requeue` option to the launcher. Please note that the changes in the launcher code will be reverted as part of the future issue [FOUNDENG-496](https://jira-pro.its.hpecorp.net:8443/browse/FOUNDENG-496). Also, the documentation changes for this issue can be found at #6141.
rb-determined-ai
pushed a commit
that referenced
this pull request
Feb 29, 2024
amandavialva01
pushed a commit
that referenced
this pull request
Mar 18, 2024
…arts of slurm jobs. (FOUNDENG-495) (#723) [FOUNDENG-453](https://jira-pro.its.hpecorp.net:8443/browse/FOUNDENG-453) [PR](https://github.hpe.com/hpe/hpc-ard-capsules-core/pull/765) sets the `--no-requeue` option for SLURM by default in the launcher code. Ideally, this should come from determined as this is the default enforced by determined not the launcher. Added code to determined to pass the `--no-requeue` option to the launcher. Please note that the changes in the launcher code will be reverted as part of the future issue [FOUNDENG-496](https://jira-pro.its.hpecorp.net:8443/browse/FOUNDENG-496). Also, the documentation changes for this issue can be found at #6141.
amandavialva01
pushed a commit
that referenced
this pull request
Mar 18, 2024
eecsliu
pushed a commit
that referenced
this pull request
Apr 18, 2024
…arts of slurm jobs. (FOUNDENG-495) (#723) [FOUNDENG-453](https://jira-pro.its.hpecorp.net:8443/browse/FOUNDENG-453) [PR](https://github.hpe.com/hpe/hpc-ard-capsules-core/pull/765) sets the `--no-requeue` option for SLURM by default in the launcher code. Ideally, this should come from determined as this is the default enforced by determined not the launcher. Added code to determined to pass the `--no-requeue` option to the launcher. Please note that the changes in the launcher code will be reverted as part of the future issue [FOUNDENG-496](https://jira-pro.its.hpecorp.net:8443/browse/FOUNDENG-496). Also, the documentation changes for this issue can be found at #6141.
eecsliu
pushed a commit
that referenced
this pull request
Apr 18, 2024
eecsliu
pushed a commit
to determined-ai/determined-release-testing
that referenced
this pull request
Apr 22, 2024
…arts of slurm jobs. (FOUNDENG-495) (determined-ai#723) [FOUNDENG-453](https://jira-pro.its.hpecorp.net:8443/browse/FOUNDENG-453) [PR](https://github.hpe.com/hpe/hpc-ard-capsules-core/pull/765) sets the `--no-requeue` option for SLURM by default in the launcher code. Ideally, this should come from determined as this is the default enforced by determined not the launcher. Added code to determined to pass the `--no-requeue` option to the launcher. Please note that the changes in the launcher code will be reverted as part of the future issue [FOUNDENG-496](https://jira-pro.its.hpecorp.net:8443/browse/FOUNDENG-496). Also, the documentation changes for this issue can be found at determined-ai#6141.
eecsliu
pushed a commit
to determined-ai/determined-release-testing
that referenced
this pull request
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The progress bar is sticking out of the task card boundary, this corrects the style.
Before:
After:
Additional work was done to unify floating UI element styles (task menus and dropdown menus)
Test Plan
Commentary (optional)