Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: antd style adjustments #732

Merged
merged 3 commits into from
Jun 23, 2020
Merged

Conversation

hkang1
Copy link
Contributor

@hkang1 hkang1 commented Jun 17, 2020

Description

2020-06-18 at 11 07 AM

Test Plan

Commentary (optional)

@cla-bot cla-bot bot added the cla-signed label Jun 17, 2020
@hkang1 hkang1 changed the title Antd style tweaks style: Ant Design style adjustments Jun 17, 2020
@hkang1 hkang1 changed the title style: Ant Design style adjustments style: antd style adjustments Jun 17, 2020
@hkang1 hkang1 requested review from hamidzr and justin-determined-ai and removed request for hamidzr June 18, 2020 17:35
@hkang1 hkang1 force-pushed the antd-style-tweaks branch 2 times, most recently from 1aa97a1 to d56af83 Compare June 22, 2020 18:00
Copy link
Contributor

@justin-determined-ai justin-determined-ai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Are we ditching Title everywhere or just on this page?

@hkang1
Copy link
Contributor Author

hkang1 commented Jun 23, 2020

LGTM! Are we ditching Title everywhere or just on this page?

This page and the Dashboard. Experiment and Trial detail pages will be using the title (more specifically the PageHeader component from Ant Design.

@hkang1 hkang1 merged commit 4a80514 into determined-ai:master Jun 23, 2020
@hkang1 hkang1 deleted the antd-style-tweaks branch February 19, 2021 23:22
tayritenour pushed a commit to tayritenour/determined that referenced this pull request Apr 25, 2023
… error: Invalid numeric value "0" [DET-9014] (determined-ai#732)

* FOUNDENG-508 Slurm GRES causes checkpoint GC task error: sbatch: error: Invalid numeric value "0"

* Fix lint issue

* Add unit tests

* fix: Check for numSlots == 0 instead of TaskTyep == CHECKPOINT_GC
eecsliu pushed a commit to eecsliu/determined that referenced this pull request Jun 23, 2023
stoksc pushed a commit that referenced this pull request Jun 26, 2023
eecsliu pushed a commit that referenced this pull request Jun 28, 2023
eecsliu pushed a commit that referenced this pull request Jun 28, 2023
stoksc pushed a commit that referenced this pull request Jul 20, 2023
eecsliu pushed a commit that referenced this pull request Jul 24, 2023
stoksc pushed a commit that referenced this pull request Oct 17, 2023
azhou-determined pushed a commit that referenced this pull request Dec 7, 2023
wes-turner pushed a commit that referenced this pull request Feb 2, 2024
@dannysauer dannysauer added this to the 0.12.10 milestone Feb 6, 2024
rb-determined-ai pushed a commit that referenced this pull request Feb 29, 2024
amandavialva01 pushed a commit that referenced this pull request Mar 18, 2024
eecsliu pushed a commit that referenced this pull request Apr 18, 2024
eecsliu pushed a commit to determined-ai/determined-release-testing that referenced this pull request Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants