-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
style: antd style adjustments #732
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hkang1
changed the title
style: Ant Design style adjustments
style: antd style adjustments
Jun 17, 2020
hkang1
requested review from
hamidzr and
justin-determined-ai
and removed request for
hamidzr
June 18, 2020 17:35
hkang1
force-pushed
the
antd-style-tweaks
branch
2 times, most recently
from
June 22, 2020 18:00
1aa97a1
to
d56af83
Compare
hkang1
force-pushed
the
antd-style-tweaks
branch
from
June 22, 2020 18:03
d56af83
to
f61f5ef
Compare
justin-determined-ai
approved these changes
Jun 23, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Are we ditching Title
everywhere or just on this page?
This page and the Dashboard. Experiment and Trial detail pages will be using the title (more specifically the |
tayritenour
pushed a commit
to tayritenour/determined
that referenced
this pull request
Apr 25, 2023
… error: Invalid numeric value "0" [DET-9014] (determined-ai#732) * FOUNDENG-508 Slurm GRES causes checkpoint GC task error: sbatch: error: Invalid numeric value "0" * Fix lint issue * Add unit tests * fix: Check for numSlots == 0 instead of TaskTyep == CHECKPOINT_GC
eecsliu
pushed a commit
to eecsliu/determined
that referenced
this pull request
Jun 23, 2023
… error: Invalid numeric value "0" [DET-9014] (determined-ai#732)
eecsliu
pushed a commit
to determined-ai/determined-release-testing
that referenced
this pull request
Apr 22, 2024
… error: Invalid numeric value "0" [DET-9014] (determined-ai#732)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Test Plan
Commentary (optional)