style: fix lint issues #740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamidzr
reviewed
Jun 18, 2020
| export type RecentTask = AnyTask & RecentEvent; | ||
| export type RecentCommandTask = CommandTask & RecentEvent | ||
| export type RecentExperimentTask = ExperimentTask & RecentEvent | ||
| export type RecentCommandTask = CommandTask & RecentEvent; |
There was a problem hiding this comment.
should we make these Error level failures so they break CI test?
There was a problem hiding this comment.
yep I like that. I wasn't sure if that was too severe but with auto fix I think that's reasonable.
There was a problem hiding this comment.
I'll update this PR to make it error level.
hamidzr
reviewed
Jun 18, 2020
hamidzr
approved these changes
Jun 18, 2020
tayritenour
pushed a commit
to tayritenour/determined
that referenced
this pull request
Apr 25, 2023
Remove podman integration tests from gate runs as they are not reliable. Disable by breaking inheritance of steps -- use test-e2e-slurm-disabled workflow that does nothing.
eecsliu
pushed a commit
to eecsliu/determined
that referenced
this pull request
Jun 23, 2023
Remove podman integration tests from gate runs as they are not reliable. Disable by breaking inheritance of steps -- use test-e2e-slurm-disabled workflow that does nothing.
stoksc
pushed a commit
that referenced
this pull request
Jun 26, 2023
Remove podman integration tests from gate runs as they are not reliable. Disable by breaking inheritance of steps -- use test-e2e-slurm-disabled workflow that does nothing.
eecsliu
pushed a commit
that referenced
this pull request
Jun 28, 2023
Remove podman integration tests from gate runs as they are not reliable. Disable by breaking inheritance of steps -- use test-e2e-slurm-disabled workflow that does nothing.
eecsliu
pushed a commit
that referenced
this pull request
Jun 28, 2023
Remove podman integration tests from gate runs as they are not reliable. Disable by breaking inheritance of steps -- use test-e2e-slurm-disabled workflow that does nothing.
stoksc
pushed a commit
that referenced
this pull request
Jul 20, 2023
Remove podman integration tests from gate runs as they are not reliable. Disable by breaking inheritance of steps -- use test-e2e-slurm-disabled workflow that does nothing.
eecsliu
pushed a commit
that referenced
this pull request
Jul 24, 2023
Remove podman integration tests from gate runs as they are not reliable. Disable by breaking inheritance of steps -- use test-e2e-slurm-disabled workflow that does nothing.
stoksc
pushed a commit
that referenced
this pull request
Oct 17, 2023
Remove podman integration tests from gate runs as they are not reliable. Disable by breaking inheritance of steps -- use test-e2e-slurm-disabled workflow that does nothing.
azhou-determined
pushed a commit
that referenced
this pull request
Dec 7, 2023
Remove podman integration tests from gate runs as they are not reliable. Disable by breaking inheritance of steps -- use test-e2e-slurm-disabled workflow that does nothing.
wes-turner
pushed a commit
that referenced
this pull request
Feb 2, 2024
Remove podman integration tests from gate runs as they are not reliable. Disable by breaking inheritance of steps -- use test-e2e-slurm-disabled workflow that does nothing.
rb-determined-ai
pushed a commit
that referenced
this pull request
Feb 29, 2024
Remove podman integration tests from gate runs as they are not reliable. Disable by breaking inheritance of steps -- use test-e2e-slurm-disabled workflow that does nothing.
amandavialva01
pushed a commit
that referenced
this pull request
Mar 18, 2024
Remove podman integration tests from gate runs as they are not reliable. Disable by breaking inheritance of steps -- use test-e2e-slurm-disabled workflow that does nothing.
eecsliu
pushed a commit
that referenced
this pull request
Apr 18, 2024
Remove podman integration tests from gate runs as they are not reliable. Disable by breaking inheritance of steps -- use test-e2e-slurm-disabled workflow that does nothing.
eecsliu
pushed a commit
to determined-ai/determined-release-testing
that referenced
this pull request
Apr 22, 2024
Remove podman integration tests from gate runs as they are not reliable. Disable by breaking inheritance of steps -- use test-e2e-slurm-disabled workflow that does nothing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Test Plan
Commentary (optional)