Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: separate reusable task table columns #741

Merged
merged 3 commits into from
Jun 22, 2020
Merged

refactor: separate reusable task table columns #741

merged 3 commits into from
Jun 22, 2020

Conversation

hamidzr
Copy link
Member

@hamidzr hamidzr commented Jun 18, 2020 •
edited by jira bot
Loading

Description

Test Plan

Commentary (optional)

@cla-bot cla-bot bot added the cla-signed label Jun 18, 2020
@hamidzr hamidzr mentioned this pull request Jun 18, 2020
Merged
@hamidzr hamidzr changed the title refactor: separate reusable taskTable columns refactor: separate reusable task table columns Jun 18, 2020
@hamidzr hamidzr requested a review from hkang1 June 18, 2020 22:29
hkang1
hkang1 approved these changes Jun 22, 2020
View reviewed changes
Copy link
Contributor

@hkang1 hkang1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reusable columns makes total sense. One minor comment about where to place shared column configs.

@hkang1 hkang1 assigned hamidzr and unassigned hkang1 Jun 22, 2020
@hamidzr hamidzr merged commit 5e93770 into determined-ai:master Jun 22, 2020
@hamidzr hamidzr deleted the separate-common-columns branch June 22, 2020 23:04
tayritenour pushed a commit to tayritenour/determined that referenced this pull request Apr 25, 2023
@stoksc @dzhu
feat: override partition description (determined-ai#741) [DET-9107]
f1c310b 
Add ability to override partition descriptions.
eecsliu pushed a commit to eecsliu/determined that referenced this pull request Jun 23, 2023
@stoksc @determined-ci
feat: override partition description (determined-ai#741) [DET-9107]
955c809 
Add ability to override partition descriptions.
stoksc added a commit that referenced this pull request Jun 26, 2023
@stoksc @hanyucui
feat: override partition description (#741) [DET-9107]
d3b819e 
Add ability to override partition descriptions.
eecsliu pushed a commit that referenced this pull request Jun 28, 2023
@stoksc @NicholasBlaskey
feat: override partition description (#741) [DET-9107]
4b5c84b 
Add ability to override partition descriptions.
eecsliu pushed a commit that referenced this pull request Jun 28, 2023
@stoksc
feat: override partition description (#741) [DET-9107]
aed47de 
Add ability to override partition descriptions.
stoksc added a commit that referenced this pull request Jul 20, 2023
@stoksc @EmilyBonar
feat: override partition description (#741) [DET-9107]
c66ad76 
Add ability to override partition descriptions.
eecsliu pushed a commit that referenced this pull request Jul 24, 2023
@stoksc @eecsliu
feat: override partition description (#741) [DET-9107]
7c99953 
Add ability to override partition descriptions.
stoksc added a commit that referenced this pull request Oct 17, 2023
@stoksc @NicholasBlaskey
feat: override partition description (#741) [DET-9107]
cdfa469 
Add ability to override partition descriptions.
azhou-determined pushed a commit that referenced this pull request Dec 7, 2023
@stoksc @azhou-determined
feat: override partition description (#741) [DET-9107]
fb3747e 
Add ability to override partition descriptions.
wes-turner pushed a commit that referenced this pull request Feb 2, 2024
@stoksc @determined-ci
feat: override partition description (#741) [DET-9107]
9564d65 
Add ability to override partition descriptions.
@dannysauer dannysauer added this to the 0.12.10 milestone Feb 6, 2024
rb-determined-ai pushed a commit that referenced this pull request Feb 29, 2024
@stoksc @djanicekpach
feat: override partition description (#741) [DET-9107]
7154bc8 
Add ability to override partition descriptions.
amandavialva01 pushed a commit that referenced this pull request Mar 18, 2024
@stoksc @determined-ci
feat: override partition description (#741) [DET-9107]
d75a4fa 
Add ability to override partition descriptions.
eecsliu pushed a commit that referenced this pull request Apr 18, 2024
@stoksc @determined-ci
feat: override partition description (#741) [DET-9107]
5d832d2 
Add ability to override partition descriptions.
eecsliu pushed a commit to determined-ai/determined-release-testing that referenced this pull request Apr 22, 2024
@stoksc @eecsliu
feat: override partition description (determined-ai#741) [DET-9107]
1d3a8c8 
Add ability to override partition descriptions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hkang1 hkang1 hkang1 approved these changes

Assignees

@hamidzr hamidzr

Labels
cla-signed
Projects
None yet
Milestone
0.12.10
Development

Successfully merging this pull request may close these issues.
3 participants
@hamidzr @hkang1 @dannysauer