-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: update the path to example configs #765
Conversation
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @eecsliu on file. In order for us to review and merge your code, please start the CLA process at https://determined.ai/cla. |
3dc004f
to
9dca17d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the PR title/squashed commit message, we'd normally go with "update" (the imperative) rather than "updating". "Mnist" in the body should also be replaced by "MNIST".
9dca17d
to
f00d97d
Compare
* docs: updating the path to example configs * docs: caught a typo
… [DET-9199] (determined-ai#765) * fix: Properly handle a "--wckey" value in sbatch file that has spaces [DET-9199] * Handle embedded double quotes * Fixed unit test * Switched to using strconv.Quote() to add the double quotes and escape embedded quotes, as Bradley had suggested * If label is empty, then wckey will be "". Otherwise, PBS fails if there's a '-P' with nothing after it. * Simply the adding of quotes
… [DET-9199] (determined-ai#765) Switched to using strconv.Quote() to add the double quotes and escape embedded quotes, as Bradley had suggested If label is empty, then wckey will be "". Otherwise, PBS fails if there's a '-P' with nothing after it.
… [DET-9199] (determined-ai#765) Switched to using strconv.Quote() to add the double quotes and escape embedded quotes, as Bradley had suggested If label is empty, then wckey will be "". Otherwise, PBS fails if there's a '-P' with nothing after it.
Description
MNIST example configs were moved from
examples/official/
toexamples/official/trial/
. This updatesCONTRIBUTING.md
to reflect the new location.Test Plan
Commentary (optional)