Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update the path to example configs #765

Merged
merged 2 commits into from
Jun 24, 2020
Merged

docs: update the path to example configs #765

merged 2 commits into from
Jun 24, 2020

Conversation

eecsliu
Copy link
Contributor

@eecsliu eecsliu commented Jun 23, 2020

Description

MNIST example configs were moved from examples/official/ to examples/official/trial/. This updates CONTRIBUTING.md to reflect the new location.

Test Plan

Commentary (optional)

@cla-bot
Copy link

cla-bot bot commented Jun 23, 2020

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @eecsliu on file. In order for us to review and merge your code, please start the CLA process at https://determined.ai/cla.

@cla-bot cla-bot bot added the cla-signed label Jun 23, 2020
Copy link
Contributor

@dzhu dzhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the PR title/squashed commit message, we'd normally go with "update" (the imperative) rather than "updating". "Mnist" in the body should also be replaced by "MNIST".

@eecsliu eecsliu changed the title docs: updating the path to example configs docs: update the path to example configs Jun 24, 2020
@eecsliu eecsliu merged commit f321a2b into master Jun 24, 2020
@eecsliu eecsliu deleted the contributing_mod branch June 24, 2020 06:36
hkang1 pushed a commit to hkang1/determined that referenced this pull request Jun 25, 2020
* docs: updating the path to example configs

* docs: caught a typo
tayritenour pushed a commit to tayritenour/determined that referenced this pull request Apr 25, 2023
… [DET-9199] (determined-ai#765)

* fix: Properly handle a "--wckey" value in sbatch file that has spaces [DET-9199]

* Handle embedded double quotes

* Fixed unit test

* Switched to using strconv.Quote() to add the double quotes and escape embedded quotes, as Bradley had suggested

* If label is empty, then wckey will be "". Otherwise, PBS fails if there's a '-P' with nothing after it.

* Simply the adding of quotes
eecsliu pushed a commit to eecsliu/determined that referenced this pull request Jun 23, 2023
… [DET-9199] (determined-ai#765)

Switched to using strconv.Quote() to add the double quotes and escape embedded quotes, as Bradley had suggested

If label is empty, then wckey will be "". Otherwise, PBS fails if there's a '-P' with nothing after it.
stoksc pushed a commit that referenced this pull request Jun 26, 2023
…DET-9199] (#765)

Switched to using strconv.Quote() to add the double quotes and escape embedded quotes, as Bradley had suggested

If label is empty, then wckey will be "". Otherwise, PBS fails if there's a '-P' with nothing after it.
eecsliu pushed a commit that referenced this pull request Jun 28, 2023
…DET-9199] (#765)

Switched to using strconv.Quote() to add the double quotes and escape embedded quotes, as Bradley had suggested

If label is empty, then wckey will be "". Otherwise, PBS fails if there's a '-P' with nothing after it.
eecsliu pushed a commit that referenced this pull request Jun 28, 2023
…DET-9199] (#765)

Switched to using strconv.Quote() to add the double quotes and escape embedded quotes, as Bradley had suggested

If label is empty, then wckey will be "". Otherwise, PBS fails if there's a '-P' with nothing after it.
stoksc pushed a commit that referenced this pull request Jul 20, 2023
…DET-9199] (#765)

Switched to using strconv.Quote() to add the double quotes and escape embedded quotes, as Bradley had suggested

If label is empty, then wckey will be "". Otherwise, PBS fails if there's a '-P' with nothing after it.
eecsliu pushed a commit that referenced this pull request Jul 24, 2023
…DET-9199] (#765)

Switched to using strconv.Quote() to add the double quotes and escape embedded quotes, as Bradley had suggested

If label is empty, then wckey will be "". Otherwise, PBS fails if there's a '-P' with nothing after it.
stoksc pushed a commit that referenced this pull request Oct 17, 2023
…DET-9199] (#765)

Switched to using strconv.Quote() to add the double quotes and escape embedded quotes, as Bradley had suggested

If label is empty, then wckey will be "". Otherwise, PBS fails if there's a '-P' with nothing after it.
azhou-determined pushed a commit that referenced this pull request Dec 7, 2023
…DET-9199] (#765)

Switched to using strconv.Quote() to add the double quotes and escape embedded quotes, as Bradley had suggested

If label is empty, then wckey will be "". Otherwise, PBS fails if there's a '-P' with nothing after it.
wes-turner pushed a commit that referenced this pull request Feb 2, 2024
…DET-9199] (#765)

Switched to using strconv.Quote() to add the double quotes and escape embedded quotes, as Bradley had suggested

If label is empty, then wckey will be "". Otherwise, PBS fails if there's a '-P' with nothing after it.
@dannysauer dannysauer added this to the 0.12.10 milestone Feb 6, 2024
rb-determined-ai pushed a commit that referenced this pull request Feb 29, 2024
…DET-9199] (#765)

Switched to using strconv.Quote() to add the double quotes and escape embedded quotes, as Bradley had suggested

If label is empty, then wckey will be "". Otherwise, PBS fails if there's a '-P' with nothing after it.
amandavialva01 pushed a commit that referenced this pull request Mar 18, 2024
…DET-9199] (#765)

Switched to using strconv.Quote() to add the double quotes and escape embedded quotes, as Bradley had suggested

If label is empty, then wckey will be "". Otherwise, PBS fails if there's a '-P' with nothing after it.
eecsliu pushed a commit that referenced this pull request Apr 18, 2024
…DET-9199] (#765)

Switched to using strconv.Quote() to add the double quotes and escape embedded quotes, as Bradley had suggested

If label is empty, then wckey will be "". Otherwise, PBS fails if there's a '-P' with nothing after it.
eecsliu pushed a commit to determined-ai/determined-release-testing that referenced this pull request Apr 22, 2024
… [DET-9199] (determined-ai#765)

Switched to using strconv.Quote() to add the double quotes and escape embedded quotes, as Bradley had suggested

If label is empty, then wckey will be "". Otherwise, PBS fails if there's a '-P' with nothing after it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants