fix: check for analytics library #794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamidzr
approved these changes
Jun 30, 2020
tayritenour
pushed a commit
to tayritenour/determined
that referenced
this pull request
Apr 25, 2023
…9278] (determined-ai#794) - Drop hard-coded 'launcher' and use the user in the dispatch response - Move the the launch of HPC queues into shared dispatch_api_client
eecsliu
pushed a commit
to eecsliu/determined
that referenced
this pull request
Jun 23, 2023
…9278] (determined-ai#794) - Drop hard-coded 'launcher' and use the user in the dispatch response - Move the the launch of HPC queues into shared dispatch_api_client
eecsliu
pushed a commit
to determined-ai/determined-release-testing
that referenced
this pull request
Apr 22, 2024
…9278] (determined-ai#794) - Drop hard-coded 'launcher' and use the user in the dispatch response - Move the the launch of HPC queues into shared dispatch_api_client
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
During an
/infopoll, it's possible forwindow.analyticsto be undefined, causing theAppcomponent to throw an error, resulting in a blank white screen.Test Plan
Commentary (optional)