Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(tests): workaround data races in uptrace/bun #8065

Merged
merged 1 commit into from
Oct 4, 2023
Merged

chore(tests): workaround data races in uptrace/bun #8065

merged 1 commit into from
Oct 4, 2023

Conversation

stoksc
Copy link
Contributor

@stoksc stoksc commented Oct 4, 2023

Description

There is a race in the Bun library, already tracked by uptrace/bun#810. This works around it so we can turn the race detector on.

Test Plan

Is a test fix.

Commentary (optional)

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

Ticket

@stoksc stoksc requested a review from a team as a code owner October 4, 2023 14:21
@cla-bot cla-bot bot added the cla-signed label Oct 4, 2023
@netlify
Copy link

netlify bot commented Oct 4, 2023 •
edited
Loading

✅ Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit 9a95474
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/651d74df3fe7f4000813808f

@stoksc stoksc requested a review from erikwilson October 4, 2023 14:23
@stoksc
Copy link
Contributor Author

stoksc commented Oct 4, 2023

landing over unrelated failures

@stoksc stoksc merged commit bcfdeac into main Oct 4, 2023
69 of 85 checks passed
@stoksc stoksc deleted the stoksc/chore/intg-race-detector-fix-4 branch October 4, 2023 15:23
@dannysauer dannysauer added this to the 0.26.2 milestone Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erikwilson erikwilson erikwilson approved these changes

@AmanuelAaron AmanuelAaron Awaiting requested review from AmanuelAaron AmanuelAaron is a code owner automatically assigned from determined-ai/backend

Assignees

@erikwilson erikwilson

Labels
cla-signed
Projects
None yet
Milestone
0.26.2
Development

Successfully merging this pull request may close these issues.
3 participants
@stoksc @erikwilson @dannysauer