Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: shell open gives unfriendly message on terminated #8074

Merged
merged 2 commits into from
Oct 4, 2023

Conversation

NicholasBlaskey
Copy link
Contributor

Description

Fix an issue where terminated shells would give a verbose error message like

shell (id: fcace6b5-5ea4-4cd3-a390-1a12500a600f) is ready.
disconnecting websocket
Exception in thread Thread-2:
Traceback (most recent call last):
  File "/Users/garrett/miniforge3/envs/det/lib/python3.9/threading.py", line 980, in _bootstrap_inner
kex_exchange_identification: Connection closed by remote host
Connection closed by UNKNOWN port 65535
To reconnect, run: det shell open fcace6b5-5ea4-4cd3-a390-1a12500a600f

Test Plan

Start and kill a shell then try to open it

We should expect the message to be this

det shell open $ID
CLI version 0.26.1-dev0 is less than master version 0.26.1-rc0. Consider upgrading the CLI.
Waiting stopped: task has been terminated.                                      
task has been terminated.

Commentary (optional)

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

Ticket

@NicholasBlaskey NicholasBlaskey added the to-cherry-pick Pull requests that need to be cherry-picked into the current release label Oct 4, 2023
@NicholasBlaskey NicholasBlaskey requested a review from a team as a code owner October 4, 2023 20:35
@cla-bot cla-bot bot added the cla-signed label Oct 4, 2023
@netlify
Copy link

netlify bot commented Oct 4, 2023

Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit 5d4086f
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/651dcdf77bd4c60009733349

@NicholasBlaskey NicholasBlaskey enabled auto-merge (squash) October 4, 2023 20:46
@NicholasBlaskey NicholasBlaskey merged commit 18d7286 into main Oct 4, 2023
68 of 83 checks passed
@NicholasBlaskey NicholasBlaskey deleted the fix_shell_open_on_deactive branch October 4, 2023 21:05
dai-release bot pushed a commit that referenced this pull request Oct 4, 2023
@dannysauer dannysauer added this to the 0.26.2 milestone Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed to-cherry-pick Pull requests that need to be cherry-picked into the current release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants